*ping*

2024-11-28T11:56:58+0000 Johannes Thyssen Tishman <johannes@thyssentishman.com>:
> 2024-11-28T11:26:52+0000 Stuart Henderson <stu@spacehopper.org>:
> > On 2024/11/27 15:27, Johannes Thyssen Tishman wrote:
> > > 2024-11-27T15:00:56+0000 Stuart Henderson <stu@spacehopper.org>:
> > > > On 2024/11/27 13:20, Johannes Thyssen Tishman wrote:
> > > > > Please find attached a port for devel/med. This port is required by
> > > > > cad/freecad, a port I intend to submit once it's dependencies have been
> > > > > comitted.
> > > > > 
> > > > > COMMENT:
> > > > > library for reading and writing MED files
> > > > > 
> > > > > DESCR:
> > > > > MED-fichier (Modélisation et Echanges de Données, in English
> > > > > Modelisation and Data Exchange) is a library to store and exchange
> > > > > meshed data or computation results. It uses the HDF5 file format
> > > > > to store the data.
> > > > > 
> > > > > All tests are passing.
> > > > > 
> > > > > Feedback? OK's? Thank you.
> > > > 
> > > > Generally looks good, a few quick comments
> > > > 
> > > > I would suggest math rather than devel
> > > > 
> > > > Some comments from my flann/plc review are relevant
> > > > 
> > > > I am surprised it actually packages with DESCR like that - I think it
> > > > would be better to avoid UTF-8
> > > 
> > > Thanks for the quick feedback Stuart. Please find an updated tarball
> > > attached with the port under math and with the following changes:
> > > 
> > > diff /usr/ports/mystuff
> > > commit - b9367957db54dde48e64a05fde8eb03f68292f55
> > > path + /usr/ports/mystuff
> > > blob - 775e665bf6f85c0cb3ee6c963552ac23ed522113
> > > file + math/med/Makefile
> > > --- math/med/Makefile
> > > +++ math/med/Makefile
> > > @@ -21,7 +21,7 @@ PERMIT_PACKAGE =	Yes
> > >  
> > >  WANTLIB +=		${COMPILER_LIBCXX} c hdf5 m z
> > >  
> > > -COMPILER =		base-clang ports-gcc base-gcc
> > > +COMPILER =		base-clang ports-gcc
> > >  MODULES =		devel/cmake
> > >  
> > >  LIB_DEPENDS =		math/hdf5
> > > blob - ae0ad2d5b94ef65223b7925784979b0f499ca283
> > > file + math/med/pkg/DESCR
> > > --- math/med/pkg/DESCR
> > > +++ math/med/pkg/DESCR
> > > @@ -1,4 +1,3 @@
> > > -MED-fichier (Modélisation et Echanges de Données, in English
> > > -Modelisation and Data Exchange) is a library to store and exchange
> > > -meshed data or computation results. It uses the HDF5 file format
> > > -to store the data.
> > > +MED-fichier (Modelisation and Data Exchange) is a library to store
> > > +and exchange meshed data or computation results. It uses the HDF5
> > > +file format to store the data.
> > > 
> > 
> > I think that's OK. The filenames in bin/ are a bit non-specific but
> > don't conflict with anything existing, and I don't suppose there's much
> > to do about that.
> 
> Thanks Stuart. I'll wait for a second dev to OK and commit these ports
> before sending another set of FreeCAD dependencies.
> 

• med.tar.gz (4K)