On 2024/12/12 15:40, Martijn van Duren wrote:
> There appear to be 2 branches of releases, the main 6.4.3 release, and
> the -r<n> releases which are annotated as for docker. While the release
> notes give the impression that there are only docker related changes, a
> got diff on the tags shows that there are also code changes included in
> there. For this reason it seemed best to lucas and me to follow the
> latter.

Doesn't seem to be the case for 4.6.3, but looking at older releases
I see what you mean. What a nuisance.

> +V = 4.6.3-r0
> +DISTFILES = ${V}.tar.gz
> +DISTNAME = coturn-docker-${V}
> +PKGNAME = turnserver-${V:S/-/./}
...
>  PORTROACH = site:https://github.com/coturn/coturn/releases/
> -SITES = https://coturn.net/turnserver/v${V}/
> +SITES = https://github.com/coturn/coturn/archive/refs/tags/docker/

Please use GH_* for github autogenerated tarballs, it takes care
of renaming the downloaded files a bit better than the default,

> +SHA256 (4.6.3-r0.tar.gz) = yIFrwM9YQT5Y6r8EDtTCHp8kHKk6cEVja1Dow0BsTrk=
> +SIZE (4.6.3-r0.tar.gz) = 535329

...this isn't really suitable for use in distfiles.

Also, while things will work with the way you're setting PKGNAME
for -r0 to -r9, it will break at -r10 (which they have used before)
and then you'd need to start using EPOCH (use pkg_check-versions to
check the sort order).

/ in the tag name adds a slight complication but it's not too
hard to deal with.

Makefile diff below will fix that.

(I didn't try building, the diff in your email got mangled somewhere
and I didn't fancy hand-applying the changes to patches/).

Index: Makefile
===================================================================
RCS file: /cvs/ports/telephony/coturn/Makefile,v
diff -u -p -r1.18 Makefile
--- Makefile	30 Aug 2024 19:16:43 -0000	1.18
+++ Makefile	12 Dec 2024 16:00:21 -0000
@@ -1,21 +1,18 @@
 COMMENT =	coturn STUN/TURN server
 
-V =		4.5.2
-DISTNAME =	turnserver-${V}
-REVISION =	5
+V =		4.6.3-r0
+GH_ACCOUNT =	coturn
+GH_PROJECT =	coturn
+GH_TAGNAME =	docker/${V}
+DISTNAME =	turnserver-${V:S/-r/pl/}
 
 CATEGORIES =	telephony
 
-HOMEPAGE =	https://github.com/coturn/coturn
-
 # BSD
 PERMIT_PACKAGE =	Yes
 
 WANTLIB += c crypto event_core event_extra event_openssl event_pthreads
 WANTLIB += hiredis intl mariadb pq pthread sqlite3 ssl m z
-
-PORTROACH =		site:https://github.com/coturn/coturn/releases/
-SITES =			https://coturn.net/turnserver/v${V}/
 
 LIB_DEPENDS =		databases/mariadb \
 			databases/postgresql \