12.12.2024 04:39, Kirill A. Korinsky пишет:
> ports@,
> 
> I'd like to import devel/intellij-fsnotifier which is port for
> https://gitlab.com/worthwhileit/bsd/fsnotifier which is used at FreeBSD.

NO_TEST=Yes can be dropped, I think;  cmake just finds 0 tests, but can pick up
new ones in future releases.

Why remove the header and library?

Why not build and ship a dynamic library as usual?  Then the port actually gets
bumped/rebuilt on inotify updates and post-install remains a single program rename.

I see no pledge usage under WRKSRC and libinotify doesn't use it, so the Makefile
comment is wrong.

The patches look like you could send them upstream.  Either way, brief comments
about what they fix/improve are useful, imho.

COMMENT says "fsnotifier", but the README diffs below have "fsNotifier".
Which one is right?

In README:
- "for Intellij-based such as":  needs capital J, misses "IDE" or so before "such"
- use active voice for brevity:  "should be integrated by ..." -> "enable it via"
- avoid drama like "dramatically" and keep it short or describe the requirements;
  libinotify's README already has it, so perhaps just refer to that and/or provide
  some numbers?
- 
> 
> I use it for last couple of months and it works on -current/amd64.
> 
> I also included a diff to update README in devel/intellij and devel/pycharm
> 
> Ok?
> 
> Index: devel/intellij/Makefile
> ===================================================================
> RCS file: /home/cvs/ports/devel/intellij/Makefile,v
> diff -u -p -r1.99 Makefile
> --- devel/intellij/Makefile	8 Sep 2024 02:15:54 -0000	1.99
> +++ devel/intellij/Makefile	12 Dec 2024 01:38:49 -0000
> @@ -1,6 +1,7 @@
>  COMMENT=		IntelliJ IDEA Java IDE
>  
>  V=			2024.2.1
> +REVISION=		0
>  DISTNAME=		ideaIC-${V}
>  PKGNAME=		intellij-${V}
>  CATEGORIES=		devel
> Index: devel/intellij/pkg/README
> ===================================================================
> RCS file: /home/cvs/ports/devel/intellij/pkg/README,v
> diff -u -p -r1.6 README
> --- devel/intellij/pkg/README	25 Jan 2023 10:54:32 -0000	1.6
> +++ devel/intellij/pkg/README	12 Dec 2024 01:38:28 -0000
> @@ -13,6 +13,10 @@ Native Libraries
>  ================
>  Functionality depending on native libraries is not likely to work.
>  
> +Filesystem notifier
> +===================
> +You may find a replacment of fsNotifier as devel/intellij-fsnotifier.

Does fsNotifier already exist in intellij and is your new port an alternative
implementation?  Then perhaps briefly explain why users benifit from it?

Or does it add currently missing functionality?

Looks like both since only one IDE has it:
	$ pkglocate fsnotifier
	pycharm-2024.1.4:devel/pycharm:/usr/local/pycharm/bin/fsnotifier


Either way, I suggest active voice in such places, e.g.

  Install the intellij-fsnotfier package to use fsNotifier.