On Mon, 16 Dec 2024 19:07:12 +0100, Jeremie Courreges-Anglas wrote:
> 
> So we got recent reports about some gcc ports failing to build for
> obscure reasons.  The last known failure was spotted  by tb@:
> 
>   https://pbot.rmdir.de/Br7B606-XUwXsk9LMLLDNA
> 
> The issue is the ugly ansidecl.h header shipped by devel/gdb and
> picked up by the compiler instead of the local copy in
> ${WRKSRC}/include.  This ansidecl.h header is installed as a support
> header for other bfd headers.  I guess the header installed with
> gdb-13.2 doesn't provide anymore the necessary compat defines used in
> the affected gcc copies.
> 
> If we want to ship some recent libbfd support, I think we should do it
> from devel/binutils.  But right now nothing in the ports tree uses
> libbfd, so the easiest way forward is to just drop bfd from devel/gdb.
> I have verified that lang/rust still builds with this diff.
> 
> I might also add fixes to the various devel/*/gcc ports at a later
> point, just in case we decide to install libbfd again.
> 
> ok?

OK.

> Index: Makefile
> ===================================================================
> RCS file: /home/cvs/ports/devel/gdb/Makefile,v
> diff -u -p -r1.90 Makefile
> --- Makefile	20 Nov 2024 17:34:07 -0000	1.90
> +++ Makefile	13 Dec 2024 16:08:59 -0000
> @@ -2,7 +2,7 @@ COMMENT=	GNU debugger
>  CATEGORIES=	devel
>  
>  DISTNAME=	gdb-13.2
> -REVISION=	3
> +REVISION=	4
>  
>  HOMEPAGE=	https://www.gnu.org/software/gdb/
>  
> @@ -28,6 +28,7 @@ COMPILER=	base-clang ports-gcc
>  SEPARATE_BUILD= Yes
>  CONFIGURE_STYLE=gnu
>  CONFIGURE_ARGS=	--program-prefix=e \
> +		--disable-install-libbfd \
>  		--disable-nls \
>  		--disable-sim \
>  		--without-guile \
> Index: pkg/PLIST
> ===================================================================
> RCS file: /home/cvs/ports/devel/gdb/pkg/PLIST,v
> diff -u -p -r1.26 PLIST
> --- pkg/PLIST	9 Nov 2024 13:33:19 -0000	1.26
> +++ pkg/PLIST	13 Dec 2024 16:14:20 -0000
> @@ -1,18 +1,7 @@
>  @bin bin/egdb
>  bin/egdb-add-index
> -include/ansidecl.h
> -include/bfd.h
> -include/bfdlink.h
> -include/ctf-api.h
> -include/ctf.h
> -include/diagnostics.h
> -include/dis-asm.h
>  include/gdb/
>  include/gdb/jit-reader.h
> -include/plugin-api.h
> -include/sframe-api.h
> -include/sframe.h
> -include/symcat.h
>  @info info/annotate.info
>  @info info/bfd.info
>  @info info/ctf-spec.info
> @@ -20,16 +9,6 @@ include/symcat.h
>  @comment @info info/sframe-spec.info
>  @info info/stabs.info
>  @comment lib/charset.alias
> -@static-lib lib/libbfd.a
> -lib/libbfd.la
> -@static-lib lib/libctf-nobfd.a
> -lib/libctf-nobfd.la
> -@static-lib lib/libctf.a
> -lib/libctf.la
> -@static-lib lib/libopcodes.a
> -lib/libopcodes.la
> -@static-lib lib/libsframe.a
> -lib/libsframe.la
>  @man man/man1/egdb-add-index.1
>  @man man/man1/egdb.1
>  @man man/man1/egdbserver.1
> 
> 
> -- 
> jca