On 2024/12/23 14:52, joshua stein wrote:
> On Mon, 23 Dec 2024 at 12:15:15 +0000, Stuart Henderson wrote:
> > here's a diff to use the relatively new DIST_TUPLE mechanism to
> > tidy up fetch/extract.  ok?
> > 
> > (I was looking at the port to see if it could be updated to use
> > llvm 18; chromium browsers will soon switch to llvm 19, and this
> > will be the only thing left using 17 - which takes about 3.5h to
> > build - but hitting a "can't reopen enum and add more constants
> > to it" error when trying to generate a new bootstrap on OpenBSD).
> 
> Here's an update to 1.14.0 that incorporates those changes, uses a 
> bootstrap built against llvm 18, and switches the port to use it.

Ah great, thank you!

> +MODCLANG_RUNDEP= yes

> @@ -51,19 +51,14 @@ LIB_DEPENDS =	converters/libiconv \
>  		devel/boehm-gc \
>  		devel/libevent2 \
>  		devel/pcre2 \
> -		devel/libyaml
> +		devel/libyaml \
> +		${MODCLANG_LIB_DEPENDS}

every LIB_DEPENDS entry needs a WANTLIB coming from the relevant port
otherwise it doesn't actually make it into the package (you may have
noticed a "LIB_DEPENDS xx not needed" message while building).

In this case it's a bit fiddly because of the subdirectory under
lib, but if you add this to WANTLIB it will do the right thing:

llvm${MODCLANG_VERSION}/lib/LLVM

("make lib-depends-check" will still whine because it doesn't handle
subdirs properly, but the built package will be correct).

With that, it's ok sthen@.