Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: [Proposal] databases/sqlite3 - enable session extension
To:
Volker Schlecht <openbsd-ports@schlecht.dev>
Cc:
ports@openbsd.org
Date:
Tue, 25 Feb 2025 01:02:07 +0100

Download raw body.

Thread
On Mon, Feb 24, 2025 at 06:45:21PM +0100, Volker Schlecht wrote:
> To have the (most probably) fixed diff out there ...

This is the diff I tested in a bulk. I don't know enugh about sqlite
to have a real opinion here, but this does look harmless.

Do you know why this isn't enabled by default?

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/databases/sqlite3/Makefile,v
> diff -u -p -r1.134 Makefile
> --- Makefile	30 Jan 2025 08:16:03 -0000	1.134
> +++ Makefile	24 Feb 2025 17:43:07 -0000
> @@ -2,10 +2,10 @@ COMMENT=	embedded SQL implementation
>  
>  DISTNAME =	sqlite-autoconf-3480000
>  PKGNAME=	sqlite3-3.48.0
> -REVISION=	0
> +REVISION=	1
>  
>  # XXX needs bumps every time :-
> -SHARED_LIBS +=  sqlite3                   37.30 # 8.6
> +SHARED_LIBS +=  sqlite3                   37.31 # 8.6
>  # sqlite suggests that users might like to assert() that library and header
>  # versions match, so bumps are needed even if function signatures don't change.
>  # ... at the current time the only one noticed is a < check (in subversion)
> @@ -35,7 +35,9 @@ CONFIGURE_ARGS +=	--enable-fts5
>  CFLAGS+=	-DSQLITE_ENABLE_UNLOCK_NOTIFY \
>  		-DSQLITE_ENABLE_FTS3 \
>  		-DSQLITE_ENABLE_DBSTAT_VTAB \
> -		-DSQLITE_ENABLE_COLUMN_METADATA=1
> +		-DSQLITE_ENABLE_COLUMN_METADATA=1 \
> +		-DSQLITE_ENABLE_SESSION \
> +		-DSQLITE_ENABLE_PREUPDATE_HOOK
>  
>  BUILD_DEPENDS =	converters/sqlite2mdoc
>  post-install: