Index | Thread | Search

From:
Stuart Henderson <stu@spacehopper.org>
Subject:
Re: net/noVNC update patch-utils_launch_sh for bad netstat argument
To:
Allan Streib <astreib@fastmail.fm>
Cc:
ports@openbsd.org
Date:
Thu, 27 Feb 2025 11:55:22 +0000

Download raw body.

Thread
thanks, I'll commit a similar fix.

On 2025/02/26 16:06, Allan Streib wrote:
> (I'm not on the list as I contribute rarely, please CC me on any replies)
> 
> This update corrects an error in netstat arguments for OpenBSD's netstat:
> 
> netstat: unknown option -- t
> 
> Updated patch-utils_launch_sh below. Hope this is useful.
> 
> Index: utils/launch.sh
> --- utils/launch.sh.orig
> +++ utils/launch.sh
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env bash
> +#!/bin/ksh
>  
>  usage() {
>      if [ "$*" ]; then
> @@ -65,7 +65,7 @@ done
>  which netstat >/dev/null 2>&1 \
>      || die "Must have netstat installed"
>  
> -netstat -ltn | grep -qs "${PORT} .*LISTEN" \

the original actually has :${PORT} to avoid matching on part of
an address (e.g. at the end of an IPv6 address)...

> +netstat -ln -p tcp | grep -qs "${PORT} .*LISTEN" \

...so we need "\.${PORT} "