On 2025/02/27 12:59, Theo Buehler wrote:
> On Thu, Feb 27, 2025 at 11:47:58AM +0000, Stuart Henderson wrote:
> > On 2025/02/27 10:44, Johannes Thyssen Tishman wrote:
> > > On a side note, I can enable the visualization subsystem now that we
> > > have vtk and leave those subsystems that are disabled by default
> > > disabled. tb@, what do you think? I opted for leaving it out initially
> > > as it is not needed by FreeCAD.
> > 
> > fwiw, I would tend to leave it out unless something needs it.
> 
> +1

The update is basically OK with me.

> > > +BUILD_DEPENDS =		devel/cjson \
> > 
> > something smells off here; it's a shared library, no "header-only
> > library" option, so why is this just a BDEP and not linked by anything?
> > 
> 
> It seems it's only needed by something called outofcore, which doesn't
> seem to be built because it depends on Boost filesystem and the cmake
> configure step can't find it for some reason.

I don't think the BUILD_DEPENDS is needed.

To be sure, I've tried building with the bundled copy removed, and also
tested with cjson installed during configure / removed during build, and
everything seems happy.

I would prefer it not to be listed as BDEP if not really used; if
something changes and it does start to get picked up for some reason,
I'd prefer to have a chance of the build failing so we'd be more likely
to notice, and could then add LIB_DEPENDS/WANTLIB and avoid broken
packages.

Perhaps consider this to make absolutely sure the bundled copy doesn't
get used?

post-extract:
        rm ${WRKSRC}/outofcore/src/cJSON.cpp