Index | Thread | Search

From:
Stuart Henderson <stu@spacehopper.org>
Subject:
Re: [Update] databases/sqlite3 3.49.1
To:
Volker Schlecht <openbsd-ports@schlecht.dev>
Cc:
ports@openbsd.org
Date:
Thu, 27 Feb 2025 18:43:54 +0000

Download raw body.

Thread
On 2025/02/27 17:14, Volker Schlecht wrote:
> Here's an update to the latest sqlite3 release. With the release of 3.49.0,
> they changed to build system to something that isn't compatible with our
> CONFIGURE_STYLE=gnu anymore, so we need an explicit do-configure target now.
> 
> The configuration should be equivalent to the current one, and the result
> works with mozilla and deno. x11/gnome/tracker was removed and I don't know
> who else uses the fts5 extension.
> 
> Opinions? OK?

two things definitely need changing:

- two symbols were removed; -DSQLITE_ENABLE_RTREE brings them back

- from autosetup/autosetup-find-tclsh:

: for tclsh in ./jimsh0 $autosetup_tclsh jimsh tclsh tclsh8.5 tclsh8.6 tclsh8.7; do
:         { $tclsh "$d/${1-autosetup-test-tclsh}"; } 2>/dev/null && exit 0
: done

please add a BUILD_DEPENDS on lang/jimtcl so that the build environment
is consistent, and to avoid races if jimtcl or tcl are installed and then
junked while configure is running.

and perhaps also:

> +		mv ${PREFIX}/lib/libsqlite3.so.{${VERSION},${LIBsqlite3_VERSION}}
> +		rm ${PREFIX}/lib/libsqlite3.so{,.0}

personally I'd do these the other way round and get rid of ${VERSION} :

	rm ${PREFIX}/lib/libsqlite3.so{,.0}
	mv ${PREFIX}/lib/libsqlite3.so.* ${PREFIX}/lib/libsqlite3.so.${LIBsqlite3_VERSION}