Index | Thread | Search

From:
Lucas Gabriel Vuotto <lucas@sexy.is>
Subject:
Re: MAINTAINER FIX: x11/emwm-utils add SUID to xmsm and xmsession
To:
izzy Meyer <izder456@disroot.org>
Cc:
ports@openbsd.org
Date:
Fri, 28 Feb 2025 03:13:53 +0000

Download raw body.

Thread
Hello,

On Thu, Feb 27, 2025 at 07:52:30PM -0600, izzy Meyer wrote:
> Hello ports@
> 
> Attached is a diff to set SUID on xmsm and xmsession which fixes the
> locking/logout/poweroff/shutdown errors. This also bumps REVISION to
> 1. 

> Index: x11/emwm-utils/Makefile
> ===================================================================
> RCS file: /cvs/ports/x11/emwm-utils/Makefile,v
> diff -u -r1.1.1.1 Makefile
> --- x11/emwm-utils/Makefile	23 Aug 2024 06:03:38 -0000	1.1.1.1
> +++ x11/emwm-utils/Makefile	28 Feb 2025 01:49:29 -0000
> @@ -1,6 +1,7 @@
>  COMMENT =	session manager and a toolchest-like application launcher
>  
>  V =		1.2
> +REVISION =	1

REVISION starts at 0.

>  DISTNAME =	emwm-utils-src-${V}
>  PKGNAME =	emwm-utils-${V}
>  
> @@ -28,5 +29,9 @@
>  		RCDIR=${WRKINST}${PREFIX}/lib/X11
>  
>  NO_TEST =	Yes
> +
> +# xmsession and xmsm need suid to lock properly
> +post-install:
> +	chmod u+s ${PREFIX}/bin/{xmsm,xmsession}

Ports usually handle this differently, by hooking into the BSD
Authentication system (man authenticate). Take a look at x11/slock,
which might be one of the simplest implementations.