On 2025/05/12 18:04, Christoph Liebender wrote:
> Am 12.05.25 um 13:22 schrieb Stuart Henderson:
> > On 2025/05/11 11:04, Christoph Liebender wrote:
> > > Actually, it seems to me that I figured out why these symlinks were
> > > necessary (but produced a faulty binary) in the first place. Because
> > > MODGO_MODNAME is not set in either mine or your attempt at building the
> > > vendored tarball, MODGO_GO111MODULE is set to off which keeps go from
> > > detecting github.com/TecharoHQ/anubis at WRKSRC. And by symlinking the
> > > package manually, internal modules were not built and therefore not included
> > > in the executable. I've manually overrided that with MODGO_GO111MODULE=auto
> > > in Makefile and now it both builds and runs ok. See the attached patch for
> > > anubis-1.18.0v0.
> > 
> > can you confirm? If this works for you I'll commit.
> 
> It does not work for me. When I access my instance, I get a 404 as soon as
> I'm redirected to
> example.org/.within.website/x/cmd/anubis/api/pass-challenge?response=foobar&nonce=hehe&redir=https%3A%2F%2Fexample.org%2F&elapsedTime=2042
> 
> That's the same behaviour I had with my symlink workaround.
> 
> > I'm not sure "auto" is a good idea there
> 
> If it is about that you may take my diff and set MODGO_GO111MODULE=on since
> that is the value it implicitly sets... Otherwise, it would neither work,
> since GO111MODULE can only be one of "on", "off", "auto". [1]
> 
> [1] https://go.dev/ref/mod#mod-commands

Thanks. I'm wary of go.port.mk and prefer to avoid anything extra that's
automatic on top. Have committed with MODGO_GO111MODULE=on.