Index | Thread | Search

From:
Stuart Henderson <stu@spacehopper.org>
Subject:
Re: [update] audio/portmidi 217 to 2.0.4
To:
Raphael Graf <r@undefined.ch>
Cc:
ports@openbsd.org
Date:
Tue, 13 May 2025 12:43:24 +0100

Download raw body.

Thread
On 2025/05/08 15:14, Raphael Graf wrote:
> The diff below updates audio/portmidi to 2.0.4.
> (I have already submitted this update some time ago, see
> https://marc.info/?l=openbsd-ports&m=168824866808246)
> 
> The project has moved to github and the version numbering scheme has changed.
> A list of changes is here: https://github.com/PortMidi/portmidi/releases
> 
> I have build-tested the following dependent ports:
> audio/audacity
> audio/mscore
> devel/pygame
> emulators/hatari
> games/dsda-doom
> games/odamex
> graphics/darktable
> 
> Everything seems to work as before, except for audio/mscore, which is now
> picking up portmidi. I will send a diff for mscore as soon as this diff is
> committed.
> I'm not 100% sure that no other port is picking it up, but I don't think so.
> 
> Any comments or oks?

Seems reasonable.

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/audio/portmidi/Makefile,v
> retrieving revision 1.7
> diff -u -p -u -p -r1.7 Makefile
> --- Makefile	7 Nov 2023 14:19:20 -0000	1.7
> +++ Makefile	8 May 2025 13:04:24 -0000
> @@ -1,33 +1,24 @@
>  COMMENT =	library for real time input and output of MIDI data
>  
> -DISTNAME =	portmidi-src-217
> -PKGNAME =	portmidi-217
> -REVISION =	1
> +GH_ACCOUNT =	PortMidi
> +GH_PROJECT =	portmidi
> +GH_TAGNAME =	v2.0.4
> +EPOCH =		0
>  
> -SHARED_LIBS =	portmidi	0.0
> +SHARED_LIBS =	portmidi	1.0
>  
>  CATEGORIES =	audio
>  
> -HOMEPAGE =	https://portmedia.sourceforge.net/

slight style recommendation (take it or leave it), I like to put EPOCH
a little further apart from where REVISION normally goes (although still
on the first screenful), makes it a little more obvious that it's not
REVISION and accidentally removing when updating later. below
SHARED_LIBS or CATEGORIES would probably be a good place.

either way, ok