Index | Thread | Search

From:
"Anthony J. Bentley" <bentley@openbsd.org>
Subject:
devel/srecord: remove USE_GROFF=Yes
To:
ports@openbsd.org
Date:
Tue, 20 May 2025 06:04:01 -0600

Download raw body.

Thread
devel/srecord sets USE_GROFF=Yes. The build uses groff(1) in three ways:

1. Runs soelim(1) on the manpages, then installs them to man1/3/5.
2. Runs groff -Tascii on the manpages, then installs them to cat1/3/5.
3. Runs groff -Tps on additional documentation, then installs to share/doc.

None of these really need USE_GROFF. In particular, the manpages
installed in step 1 format fine with mandoc(1); I diffed the output
and found nothing problematic. So we can replace USE_GROFF with a
build dependency on groff.

This means the items in step 2 are useless. But we don't have to remove
them, since update-plist apparently ignores them anyway.

ok?

--- devel/srecord/Makefile
+++ devel/srecord/Makefile
@@ -3,7 +3,7 @@ BROKEN-arm=	SIGBUS in ps2pdf
 COMMENT=		collection of tools for manipulating EPROM load files
 
 DISTNAME=		srecord-1.64
-REVISION =		4
+REVISION =		5
 CATEGORIES=		devel
 
 SHARED_LIBS +=  srecord              0.0      # 0.0
@@ -20,11 +20,10 @@ WANTLIB += c gcrypt gpg-error iconv intl m ${COMPILER_
 COMPILER =		base-clang ports-gcc base-gcc
 
 BUILD_DEPENDS=		devel/boost \
-			print/ghostscript/gnu
+			print/ghostscript/gnu \
+			textproc/groff
 LIB_DEPENDS=		security/libgcrypt
 
-USE_GROFF=		Yes
-
 CONFIGURE_STYLE=	gnu
 CONFIGURE_ENV=		CPPFLAGS="-I${LOCALBASE}/include" \
 			LDFLAGS="-L${LOCALBASE}/lib"
blob - 0bdbd343667948b4e8a7a889d374485559647938
blob + 494e5249ac7fb96aae86ba8ec4269d9fd8e4699f
--- devel/srecord/pkg/PLIST
+++ devel/srecord/pkg/PLIST
@@ -153,7 +153,7 @@ include/srecord/quit/prefix.h
 include/srecord/record.h
 include/srecord/srecord.h
 include/srecord/string.h
-lib/libsrecord.a
+@static-lib lib/libsrecord.a
 lib/libsrecord.la
 @lib lib/libsrecord.so.${LIBsrecord_VERSION}
 lib/pkgconfig/srecord.pc