Index | Thread | Search

From:
"Anthony J. Bentley" <bentley@openbsd.org>
Subject:
Re: [FIX] misc/screen: garbled text in the man page
To:
an9wer@SDF.ORG
Cc:
ports@openbsd.org
Date:
Thu, 22 May 2025 06:05:38 -0600

Download raw body.

Thread
an9wer@SDF.ORG writes:
> Hi ports@
>
> I installed the latest version of the misc/screen package 
> (screen-5.0.1.2.tgz), and noticed that the "DEFAULT KEY BINDINGS" 
> section in the installed man page is corrupted and unreadable - it is 
> supposed to be a table of key bindings and their descriptions, but 
> instead, it appears as garbled text.
>
> I found that during the package creation (pkg_create(1)), the original 
> man page (man/man1/screen.1) in the fake installation directory is 
> reformatted using groff and stored as man/cat1/screen.0 in the final 
> package. However, the original man page is already well-formatted, and 
> there is no need to reformat it.

Other than the usual .I/.br-in-tables and some minor spacing differences,
I see no formatting issues.

But: removing USE_GROFF needs a REVISION bump. And we might as well
remove it from screen-shm too. So unless anyone objects, I'll go ahead
and commit this soon:

diff /usr/ports
path + /usr/ports
commit - 1a6a321c44645025b49e4a3a7c9b1fd414f0fb61
blob - ba7d7bd78b9f49ac50fc7a03d81b2a8bb08f4f04
file + misc/screen/Makefile
--- misc/screen/Makefile
+++ misc/screen/Makefile
@@ -2,6 +2,7 @@ COMMENT=	multi-screen window manager
 
 DISTNAME=	screen-5.0.1
 PKGNAME=	screen-5.0.1.2
+REVISION=	0
 DISTFILES=	${DISTNAME}-2{${DISTNAME}}.tar.gz
 CATEGORIES=	misc
 SITES=		${SITE_GNU:=screen/}
@@ -19,7 +20,6 @@ CONFIGURE_STYLE= gnu
 CONFIGURE_ARGS=	--with-sys-screenrc="${SYSCONFDIR}/screenrc" --disable-pam
 
 USE_GMAKE=	Yes
-USE_GROFF=	Yes
 
 FLAVORS=	static
 FLAVOR?=
commit - 1a6a321c44645025b49e4a3a7c9b1fd414f0fb61
blob - 7c9c57e5ae2b1aed345fcf30a17a4b5396aa23dc
file + misc/screen-shm/Makefile
--- misc/screen-shm/Makefile
+++ misc/screen-shm/Makefile
@@ -4,7 +4,7 @@ COMMENT=	multi-screen window manager, with shm support
 PORTROACH=	ignore:1
 
 DISTNAME=	screen-4.0.3
-REVISION=	9
+REVISION=	10
 CATEGORIES=	misc
 SITES=		${SITE_GNU:=screen/}
 
@@ -18,7 +18,6 @@ WANTLIB=	c curses util
 AUTOCONF_VERSION=2.57
 CONFIGURE_STYLE= autoconf no-autoheader
 CONFIGURE_ARGS=	--with-sys-screenrc="${SYSCONFDIR}/screenrc"
-USE_GROFF=	Yes
 
 FLAVORS=	shm
 FLAVOR?=	shm