Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: Porting astral-sh/uv
To:
Laurent Cheylus <foxy@free.fr>
Cc:
ports@openbsd.org
Date:
Fri, 4 Jul 2025 17:47:14 +0200

Download raw body.

Thread
On Fri, Jul 04, 2025 at 04:30:38PM +0200, Laurent Cheylus wrote:
> Re Theo,
> 
> ----- Mail original -----
> > Someone needs to review this properly before it can go in. Once
> > that's done and if Laurent or Denis are willing to take maintainer and want
> > to keep this reasonably up-to-date, I think I'll be ok with someone else
> > importing it.
> 
> After review, build and tests OK on current/amd64 with Rust 1.88.0
> 
> Attached a patch for your Makefile:
> 
> - use 'devel' for CATEGORY
> - reformat (use tabs instead of spaces) + reorder some variables
> - use https://docs.astral.sh/uv/ as HOMEPAGE instead of GitHub astral-sh/uv
> - take maintainership for this port
> - remove MODCARGO_INSTALL_TARGET_PATHS (no need when using a specific 'do-install')
> - add SEPARATE_BUILD (not defined in devel/cargo/cargo.port.mk)
> - use MODCARGO_TARGET_DIR in 'do-install'

These all make sense to me. I had to hand-apply the big second hunk of
your diff because it didn't apply on top of my tarball. There were also
some tiny whitespace issues in the + part of that diff (which I fixed).

Attached the tarball which I think is ready to import as devel/uv. I
can do that or someone else can do it with my ok.