On 2025/07/24 16:28, Chris Billington wrote:
> Proposed port productivity/jstock, a Java stock price/analysis program,
> is attached. Upstream: https://jstock.org. A matching Android
> application also exists.
> 
> This is my first Java port so a practised eye to review and test would
> be much appreciated.
> 
> Happy to act as Maintainer if accepted.
> 
> -- 
> Chris Billington <emulti@disroot.org>

some comments from a read-through:

: JAVA_HOME=/usr/local/jdk-1.8.0/
: PATH=$PATH:/usr/local/jdk-1.8.0/bin/

don't hardcode. use javaPathHelper to retrieve the paths based on
package installation info.

if it specifically needs 1.8 then set it in MODJAVA_VER.

: _JAVA_AWT_WM_NONREPARENTING=1

not exported so this does nothing. also it's WM-specific, shouldn't be
set in general anyway.


: COMMENT=		Stock market software for 28 countries

lowercase 'stock'

I'd skip the number and just use e.g. 'various' to avoid it getting out
of sync with updates. maybe include 'gui' or similar?

: V =			1.0.7.60
: DISTNAME=		jstock-${V}
..
: EXTRACT_SUFX =	.zip
: DISTFILES =	${DISTNAME}-bin${EXTRACT_SUFX}

there are various neater ways to do this, I'd go with

V =			1.0.7.60
DISTNAME=		jstock-${V}
..
EXTRACT_SUFX=		-bin.zip

don't mix "VAR=" and "VAR =", stick to one

: SITES =         ${HOMEPAGE}/releases/download/release_1-0-7-60/

.../release-${V:S/./-/g}

: post-extract:
: 	mv ${WRKDIR}/jstock ${WRKDIR}/${DISTNAME}

WRKDIST=${WRKDIR}/jstock

amd don't list Homepage in DESCR, it's added automatically so it's now
doubled.

README should follow the standard formatting used in other ports.