On 2025/07/25 09:05, Otto Moerbeek wrote:
> On Thu, Jul 24, 2025 at 04:01:02PM +0100, Stuart Henderson wrote:
> 
> > On 2025/07/21 15:46, Otto Moerbeek wrote:
> > > -CONFIGURE_STYLE=	autoconf
> 
> Right
> 
> > 
> > should patches/patch-configure_ac be removed now?
> > 
> > > +MODULES+=            devel/cargo
> > 
> > is rust a hard dep now or is it still optional?
> > (not a problem but it will kill a few archs)
> 
> If the new yaml config is not enabled, rust isn't needed. But I have
> no clue how to formulate: "if cargo is not available, set -Dyaml=no".
> I expect -Dyaml=auto to not be that smart.
> 
> Any hint?

.include <bsd.port.arch.mk>
.if ${PROPERTIES:Mrust)
[...]
.else
[...]
.endif

obviously it would need to cover the MODULES+=devel/cargo, MODCARGO_*,
pre-configure, I didn't check if anything else.

Up to you as maintainer whether you actually want to do this or now.

(Pulling in bsd.port.arch.mk needs to happen after DEBUG_PACKAGES
is set; you have that high enough in the Makefile that it's not
a problem here but thought I'd mention it for any other readers)

> > (looks like curses and m can be dropped from WANTLIB too?)

that was from 'make port-lib-depends-check' btw:

dnsdist-2.0.0(net/dnsdist):
Extra:  curses.16 m.10
> 
> That would surprise me, as libedit and floating point functions *are*
> used.

I assume curses comes via an inter-library dependency. Not sure why
no libm, but..

$ objdump -p ../fake-aarch64/usr/local/bin/dnsdist | grep NEEDED
  NEEDED      /usr/local/lib/liblua5.3.so.5.3
  NEEDED      libcdb.so.0.0
  NEEDED      libfstrm.so.0.0
  NEEDED      libcrypto.so.57.0
  NEEDED      libedit.so.7.0
  NEEDED      libnghttp2.so.0.23
  NEEDED      libsodium.so.10.2
  NEEDED      libssl.so.60.0
  NEEDED      /usr/local/lib/liblmdb.so.0.0
  NEEDED      libc++.so.11.0
  NEEDED      libc++abi.so.8.0
  NEEDED      libpthread.so.28.0
  NEEDED      libc.so.101.0