On 2025/08/15 01:36, Lloyd wrote:
> Dear ports@,
> 
> Attached please find a new port for:
> 
> libt3config: A library for reading and writing configuration files.

some tweaks, from a quick look they probably apply to the other ports
you sent in that batch too

: --- Makefile-	Fri Aug 15 08:02:27 2025
: +++ Makefile	Fri Aug 15 08:11:18 2025
: @@ -2,17 +2,16 @@ COMMENT =		reading/writing simple structured config fi
:  
:  DISTNAME =		libt3config-1.0.0
:  
: -SHARED_LIBS =		t3config 0.1
: +SHARED_LIBS =		t3config 0.0

start with 0.0 for new ports (then follow the rules from
https://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs
for updates)

:  CATEGORIES =		devel

(have left, but textproc may be a better category, devel has a lot of
subdirs already and we try to choose another category if possible)

:  HOMEPAGE =		https://os.ghalkes.nl/t3/libt3config.html
:  
: -# GPLv3
: -
: +# GPLv3 only

be exact (this one doesn't day "or later" so it's v3 only not v3+)

:  PERMIT_PACKAGE =	Yes
:  
: -WANTLIB = 		intl iconv pthread
: +WANTLIB =		intl iconv pthread

whitespace nit

:  SITES =			https://os.ghalkes.nl/dist/
:  EXTRACT_SUFX =		.tar.bz2
: @@ -20,12 +19,13 @@ EXTRACT_SUFX =		.tar.bz2
:  BUILD_DEPENDS =		devel/gettext,-tools
:  LIB_DEPENDS =		devel/gettext,-runtime
:  
: -CONFIGURE_STYLE =	gnu
: +CONFIGURE_STYLE =	simple

it's not autoconf

: -CONFIGURE_ARGS =	--prefix=${LOCALBASE}
: +CONFIGURE_ARGS =	--prefix=${TRUEPREFIX}

that's "dir where this port installs files" which is TRUEPREFIX not
LOCALBASE

: -CONFIGURE_ENV =		CFLAGS="-I${LOCALBASE}/include" \
: +CONFIGURE_ENV =		CFLAGS="${CFLAGS} -I${LOCALBASE}/include" \

generally don't override default CFLAGS, add to it. (since this is for
-I, for many ports it would be better to pass via CPPFLAGS, but the
configure script here doesn't handle that)

:  			LDFLAGS="-L${LOCALBASE}/lib"
:  
: -CFLAGS =		-I${LOCALBASE}/include
: -LDFLAGS =		-L${LOCALBASE}/lib

CONFIGURE_ENV is enough for those in this port so no need to touch
those make vars

: +MAKE_FLAGS =		SILENCELT= SILENTCCLT= SILENTLDLT=

avoid silencing the build commands, we want to see the command lines to
make sure nothing was overridden by mistake

: +NO_TEST =		Yes

self explanatory

:  .include <bsd.port.mk>
: