Index | Thread | Search

From:
Volker Schlecht <openbsd-ports@schlecht.dev>
Subject:
Re: sysutils/just: add bash and zsh shell completions
To:
Edd Barrett <edd@theunixzoo.co.uk>
Cc:
ports@openbsd.org
Date:
Fri, 15 Aug 2025 15:18:32 +0200

Download raw body.

Thread
ok volker@

On 2025-08-15 13:55, Edd Barrett wrote:
>Hi,
>
>I didn't realise that just has shell completions. The just binary is capable of
>generating them on the fly.
>
>This diff adds zsh and bash completions to our package. fish already ships with
>just completions. We could add the more obscure shells (elvish, nushell) later
>if anyone needs (and is prepared to test) them.
>
>I've tested the bash and zsh completions.
>
>OK?
>
>
>Index: Makefile
>===================================================================
>RCS file: /cvs/ports/sysutils/just/Makefile,v
>diff -u -p -r1.1.1.1 Makefile
>--- Makefile	11 Aug 2025 20:54:42 -0000	1.1.1.1
>+++ Makefile	15 Aug 2025 12:42:39 -0000
>@@ -1,6 +1,7 @@
> COMMENT =	tool for running project-specific commands
>
> V =		1.42.4
>+REVISION =	0
> PKGNAME =	just-${V}
>
> DIST_TUPLE +=	github casey just ${V} .
>@@ -19,9 +20,17 @@ CONFIGURE_STYLE =	cargo
> SEPARATE_BUILD =	Yes
>
> EXAMPLES=${PREFIX}/share/examples/just/
>+ZSH_COMPS=${PREFIX}/share/zsh/site-functions/
>+BASH_COMPS=${PREFIX}/share/bash-completion/completions/
> post-install:
> 	mkdir -p ${EXAMPLES}
> 	cp -r ${WRKSRC}/examples/* ${EXAMPLES}
>+
>+	# note: fish shell already ships with just completions.
>+	${INSTALL_DATA_DIR} ${BASH_COMPS}
>+	${PREFIX}/bin/just --completions bash > ${BASH_COMPS}/just
>+	${INSTALL_DATA_DIR} ${ZSH_COMPS}
>+	${PREFIX}/bin/just --completions zsh > ${ZSH_COMPS}/_just
>
> # Note that one test fails because $USER isn't set in the environment for some
> # reason. The test doesn't fail outside of the ports infrastructure.
>Index: pkg/PLIST
>===================================================================
>RCS file: /cvs/ports/sysutils/just/pkg/PLIST,v
>diff -u -p -r1.1.1.1 PLIST
>--- pkg/PLIST	11 Aug 2025 20:54:42 -0000	1.1.1.1
>+++ pkg/PLIST	15 Aug 2025 12:42:49 -0000
>@@ -1,4 +1,7 @@
> @bin bin/just
>+share/bash-completion/
>+share/bash-completion/completions/
>+share/bash-completion/completions/just
> share/examples/just/
> share/examples/just/cross-platform.just
> share/examples/just/keybase.just
>@@ -6,3 +9,6 @@ share/examples/just/kitchen-sink.just
> share/examples/just/powershell.just
> share/examples/just/pre-commit.just
> share/examples/just/screenshot.just
>+share/zsh/
>+share/zsh/site-functions/
>+share/zsh/site-functions/_just
>
>-- 
>Best Regards
>Edd Barrett
>
>https://www.theunixzoo.co.uk
>