Index | Thread | Search

From:
Jeremie Courreges-Anglas <jca@wxcvbn.org>
Subject:
Re: devel/readline: fix readline.pc
To:
Landry Breuil <landry@openbsd.org>
Cc:
Matthieu Herrb <matthieu@openbsd.org>, ports@openbsd.org
Date:
Sat, 16 Aug 2025 11:52:56 +0200

Download raw body.

Thread
On Sat, Aug 16, 2025 at 11:40:00AM +0200, Landry Breuil wrote:
> Le Sat, Aug 16, 2025 at 11:03:34AM +0200, Matthieu Herrb a écrit :
> > Hi,
> > 
> > The inormation provided by /usr/local/lib/pkg-config/readline.pc is
> > not correct and leads to mix with base readline. This patch fixes it
> > so that ports that use pkg-config(1) to determine if readline is
> > available pick up the correct includes and libs.
> > 
> > comments, ok ?
> 
> that looks correct, i'm just wary of the consequences on the consumers,
> be it WANTLIB or behaviour changes.. worth putting in a bulk ?

I just checked, all the consumers have *e*readline in WANTLIB.
Regarding behavior change *at* runtime, a bulk build can't really
help, can it?

The main fallout I'm thinking of is that some ports might start to
pick readline from ports.  By default bulk build might catch a few but
one should prevent dpb from junking devel/readline and then should
skim through the logs to assess all the offenders.

Another approach is to fix the hidden deps as they appear. ;)

-- 
jca