Index | Thread | Search

From:
Peter Hessler <phessler@theapt.org>
Subject:
Re: py-qt6: split configure and build steps
To:
Theo Buehler <tb@theobuehler.org>
Cc:
Landry Breuil <landry@openbsd.org>, ports@openbsd.org
Date:
Tue, 19 Aug 2025 16:40:35 +0200

Download raw body.

Thread
On 2025 Aug 19 (Tue) at 16:29:13 +0200 (+0200), Theo Buehler wrote:
:> some c++ files are still built at the start of configure.
:
:These are all called cfgtest_QtFoo.cpp and look like the sip-build
:equivalent of configtest.c. Since C++ compilation is slow, and Qt is
:huge, I don't think there's much we can do about it.
:
:Similarly for the eternal generation steps. I think these do belong into
:the configure step. Whether they can be sped up we probably need to ask
:the kernel folks :)
:
:Here's the analogous diff for py-qt5 where 'update-plist' wanted to
:move a @pkgpath for some reason. exopi used configure=8543.77, I got:
:
:configure: ~11 min
:-j8 build: ~1 2min
:
:The way the build system works I'm not really worried that this can
:break anything at runtime, but any testing is of course appreciated.
:

OK


:Index: Makefile
:===================================================================
:RCS file: /cvs/ports/x11/py-qt5/Makefile,v
:diff -u -p -r1.45 Makefile
:--- Makefile	21 Dec 2024 11:39:18 -0000	1.45
:+++ Makefile	19 Aug 2025 14:13:23 -0000
:@@ -3,7 +3,7 @@ COMMENT=	Python bindings for Qt5
: MODPY_DISTV=	5.15.11
: DISTNAME=	PyQt5-${MODPY_DISTV}
: PKGNAME=	py-qt5-${MODPY_DISTV}
:-REVISION=	0
:+REVISION=	1
: 
: CATEGORIES=	x11 devel
: 
:@@ -59,13 +59,14 @@ MODPY_PI=	Yes
: # https://www.riverbankcomputing.com/static/Docs/PyQt5/installation.html#building-pyqt5
: CONFIGURE_STYLE= simple
: CONFIGURE_SCRIPT= ${LOCALBASE}/bin/sip-build
:-CONFIGURE_ARGS =	--verbose --confirm-license
:+CONFIGURE_ARGS=	--no-make --verbose --confirm-license
: 
: MAKE_FLAGS=	-C build \
: 		CC=${CC} \
: 		CXX=${CXX} \
: 		COPTS="${CFLAGS}" \
:-		CXXOPTS="${CXXFLAGS}"
:+		CXXOPTS="${CXXFLAGS}" \
:+		MAKE_JOBS=${MAKE_JOBS}
: 
: FAKE_FLAGS=	INSTALL_ROOT=${DESTDIR}
: 
:Index: pkg/PLIST
:===================================================================
:RCS file: /cvs/ports/x11/py-qt5/pkg/PLIST,v
:diff -u -p -r1.14 PLIST
:--- pkg/PLIST	21 Dec 2024 11:39:18 -0000	1.14
:+++ pkg/PLIST	19 Aug 2025 14:12:58 -0000
:@@ -1,5 +1,5 @@
:-@pkgpath x11/py-qt5,python3
: @conflict py-qt5-*
:+@pkgpath x11/py-qt5,python3
: @pkgpath x11/py-qt5,-main
: bin/pylupdate5
: bin/pyrcc5
:

-- 
"... the Mayo Clinic, named after its founder, Dr. Ted Clinic ..."
		-- Dave Barry