Index | Thread | Search

From:
Stuart Henderson <stu@spacehopper.org>
Subject:
Re: [update] tigervnc to 1.15.0
To:
Florian Viehweger <openbsd@out-of-creativity.de>
Cc:
ports@openbsd.org
Date:
Sat, 6 Sep 2025 14:42:16 +0100

Download raw body.

Thread
On 2025/09/06 14:58, Florian Viehweger wrote:
> Hi,
> 
> this is an update for tigervnc to 1.15.0.
> 
> Some testing done on amd64. No issues found for my use case.
> 
> portcheck, 'make port-lib-depends-check' and 'make test' are happy.

Thanks. Also needs "make update-patches", and -DENABLE_PWQUALITY=OFF
in CONFIGURE_ARGS (otherwise libpwquality gets picked up if present at
build time; I'd prefer not to add the dep).

I think it would also make sense to update XORG_V to 21.1.8 while
there.

Does this still work for your use-case?

Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/tigervnc/Makefile,v
diff -u -p -r1.29 Makefile
--- Makefile	27 Jul 2025 22:55:12 -0000	1.29
+++ Makefile	6 Sep 2025 13:39:03 -0000
@@ -2,10 +2,9 @@ COMMENT=	high performance, multi-platfor
 
 GH_ACCOUNT=	TigerVNC
 GH_PROJECT=	tigervnc
-GH_TAGNAME=	v1.14.1
-REVISION=	0
+GH_TAGNAME=	v1.15.0
 
-XORG_V=		21.1.13
+XORG_V=		21.1.18
 
 # update the patch filename in the post-patch target if moving to a new
 # major branch of xorg-server
@@ -50,7 +49,8 @@ COMPILER=	base-clang
 CONFIGURE_ARGS=	-DMAN_DIR="${TRUEPREFIX}/man" \
 		-DDOC_DIR="${TRUEPREFIX}/share/doc/tigervnc" \
 		-DCMAKE_INSTALL_FULL_SYSCONFDIR="${TRUEPREFIX}/share/examples/tigervnc" \
-		-DINSTALL_SYSTEMD_UNITS=OFF
+		-DINSTALL_SYSTEMD_UNITS=OFF \
+		-DENABLE_PWQUALITY=OFF
 # ld: error: undefined symbol: vtable for rfb::UnixPasswordValidator
 # might need something more to enable nettle (sha/aes support) while pam is disabled?
 CONFIGURE_ARGS+= -DENABLE_NETTLE=OFF
Index: distinfo
===================================================================
RCS file: /cvs/ports/x11/tigervnc/distinfo,v
diff -u -p -r1.13 distinfo
--- distinfo	26 Oct 2024 13:49:00 -0000	1.13
+++ distinfo	6 Sep 2025 13:39:03 -0000
@@ -1,8 +1,8 @@
-SHA256 (tigervnc-1.14.1.tar.gz) = V50NBOtbgG0kDpmjx1aziTaFnm99svSvDVZWzJqYnXw=
+SHA256 (tigervnc-1.15.0.tar.gz) = fyMZBoAeifCaIS6GcB898XIuNnZ9YFWk5hk5BXBUhTc=
 SHA256 (tigervnc-vncserver-1.10.1.man) = SYPtbv1V+i4qPDYNS7s5yfcD77b6Kc5PbY/TRZmb6O0=
 SHA256 (tigervnc-vncserver-1.10.1.pl) = QKXeRAhhWcwN8+2dSH1x48qj5JPVNafgdhuNRZG7WuM=
-SHA256 (xorg-server-21.1.13.tar.xz) = tFoC1ZQ/ciNqNg08yX51E0qk9jA5/4jARoa1CKPcdAw=
-SIZE (tigervnc-1.14.1.tar.gz) = 2097932
+SHA256 (xorg-server-21.1.18.tar.xz) = yHjRkw2Hcl1KW/SYwk9L6BMNWyZGqf0PKZTe/5ARY1I=
+SIZE (tigervnc-1.15.0.tar.gz) = 2126369
 SIZE (tigervnc-vncserver-1.10.1.man) = 7844
 SIZE (tigervnc-vncserver-1.10.1.pl) = 24313
-SIZE (xorg-server-21.1.13.tar.xz) = 4963952
+SIZE (xorg-server-21.1.18.tar.xz) = 5037376
Index: patches/patch-CMakeLists_txt
===================================================================
RCS file: /cvs/ports/x11/tigervnc/patches/patch-CMakeLists_txt,v
diff -u -p -r1.6 patch-CMakeLists_txt
--- patches/patch-CMakeLists_txt	15 Oct 2024 16:52:12 -0000	1.6
+++ patches/patch-CMakeLists_txt	6 Sep 2025 13:39:03 -0000
@@ -1,7 +1,7 @@
 Index: CMakeLists.txt
 --- CMakeLists.txt.orig
 +++ CMakeLists.txt
-@@ -288,7 +288,7 @@ if (ENABLE_NETTLE)
+@@ -341,7 +341,7 @@ if (ENABLE_NETTLE)
  endif()
  
  # Check for PAM library
@@ -10,7 +10,7 @@ Index: CMakeLists.txt
    check_include_files(security/pam_appl.h HAVE_PAM_H)
    set(CMAKE_REQUIRED_LIBRARIES -lpam)
    check_function_exists(pam_start HAVE_PAM_START)
-@@ -301,7 +301,7 @@ if(UNIX AND NOT APPLE)
+@@ -354,7 +354,7 @@ if(UNIX AND NOT APPLE)
  endif()
  
  # Check for SELinux library
@@ -19,7 +19,7 @@ Index: CMakeLists.txt
    check_include_files(selinux/selinux.h HAVE_SELINUX_H)
    if(HAVE_SELINUX_H)
      set(CMAKE_REQUIRED_LIBRARIES -lselinux)
-@@ -314,7 +314,7 @@ if(UNIX AND NOT APPLE)
+@@ -367,7 +367,7 @@ if(UNIX AND NOT APPLE)
  endif()
  
  # check for systemd support (socket activation)
Index: patches/patch-common_rfb_CMakeLists_txt
===================================================================
RCS file: /cvs/ports/x11/tigervnc/patches/patch-common_rfb_CMakeLists_txt,v
diff -u -p -r1.4 patch-common_rfb_CMakeLists_txt
--- patches/patch-common_rfb_CMakeLists_txt	15 Oct 2024 16:52:12 -0000	1.4
+++ patches/patch-common_rfb_CMakeLists_txt	6 Sep 2025 13:39:03 -0000
@@ -1,7 +1,7 @@
 Index: common/rfb/CMakeLists.txt
 --- common/rfb/CMakeLists.txt.orig
 +++ common/rfb/CMakeLists.txt
-@@ -92,7 +92,7 @@ if(WIN32)
+@@ -91,7 +91,7 @@ if(WIN32)
    target_sources(rfb PRIVATE WinPasswdValidator.cxx)
  endif(WIN32)
  
Index: patches/patch-common_rfb_SSecurityPlain_cxx
===================================================================
RCS file: /cvs/ports/x11/tigervnc/patches/patch-common_rfb_SSecurityPlain_cxx,v
diff -u -p -r1.4 patch-common_rfb_SSecurityPlain_cxx
--- patches/patch-common_rfb_SSecurityPlain_cxx	15 Oct 2024 16:52:12 -0000	1.4
+++ patches/patch-common_rfb_SSecurityPlain_cxx	6 Sep 2025 13:39:03 -0000
@@ -19,7 +19,7 @@ Index: common/rfb/SSecurityPlain.cxx
      if (users[i] == "%u") {
        struct passwd *pw = getpwnam(username);
        if (pw && pw->pw_uid == getuid())
-@@ -72,7 +72,7 @@ SSecurityPlain::SSecurityPlain(SConnection* sc) : SSec
+@@ -72,7 +72,7 @@ SSecurityPlain::SSecurityPlain(SConnection* sc_) : SSe
  {
  #ifdef WIN32
    valid = new WinPasswdValidator();
@@ -27,4 +27,4 @@ Index: common/rfb/SSecurityPlain.cxx
 +#elif !defined(__APPLE__) && !defined(__OpenBSD__)
    valid = new UnixPasswordValidator();
  #else
-   valid = NULL;
+   valid = nullptr;
Index: patches/patch-unix_xserver_hw_vnc_Makefile_am
===================================================================
RCS file: /cvs/ports/x11/tigervnc/patches/patch-unix_xserver_hw_vnc_Makefile_am,v
diff -u -p -r1.6 patch-unix_xserver_hw_vnc_Makefile_am
--- patches/patch-unix_xserver_hw_vnc_Makefile_am	26 Oct 2024 13:49:00 -0000	1.6
+++ patches/patch-unix_xserver_hw_vnc_Makefile_am	6 Sep 2025 13:39:03 -0000
@@ -1,7 +1,7 @@
 Index: unix/xserver/hw/vnc/Makefile.am
 --- unix/xserver/hw/vnc/Makefile.am.orig
 +++ unix/xserver/hw/vnc/Makefile.am
-@@ -55,7 +55,7 @@ Xvnc_LDADD = \
+@@ -60,7 +60,7 @@ Xvnc_LDADD = \
  	$(LOCAL_LIBS) \
  	$(XSERVER_SYS_LIBS) \
  	$(XVNC_SYS_LIBS) \