On 2025/09/13 18:11, Jan Klemkow wrote:
> On Thu, Jul 11, 2024 at 03:17:16PM +0200, Martin Hauser wrote:
> > I got another new port here, following license-scanner yesterday. I
> > discovered after playing around more with license scanner that the
> > identification rate can be enhanced by using updated data from the SPDX
> > Project. These files need to be processed by license-scanner to be
> > usable when scanning for licenses, but then can be used to recognize
> > more obscure or older licenses that are not built into the tool.
> > 
> > There's a few things I'm not sure about on this port, especially
> > whether having RUN_DEPENDS on license-scanner is actually correct,
> > given that these are only data created from what SPDX provides.
> > 
> > I'd appreciate any tests and feedback, it works on my amd64 machine
> > both for the port itself, as well as using its output to detect
> > licenses (an easy test is using lgpl 2, which is only detected once
> > the data is used).
> > 
> > Any feedback and suggestions welcome.
> 
> I tested you port.  Works for me.  I fixed a few spacing issues.
> It looks ok for me, but I'm not a ports expert.
> 
> Thanks,
> jan

It needs NO_TEST=Yes:

$ make test
===>  Regression tests for license-scanner-spdx-licenses-3.24.0
make: cannot open Makefile.

Otherwise looks good. We could go either way for the RUN_DEPENDS -
I don't think it's a problem to have it.