On 2025/09/16 18:01, Nam Nguyen wrote:
> Nam Nguyen writes:
> 
> ping. The diff is attached.
> 
> > Here is a diff for emulators/libchdr to update to a newer commit on
> > 20250608. It is needed for a emulators/flycast I am sending after.
> >
> > This diff:
> > - adds a minor bump
> > - links with archivers/zstd instead of the newly bundled zstd
> >
> > huffman.h has a function that now returns enum huffman_error instead of
> > void. But, this function seems to be mostly internal and is not used by
> > consumers emulators/libretro-pcsx-rearmed and emulators/flycast. This
> > does not necessitate a major bump. Whereas before the code in libchdr
> > ignored the return value, it now uses the return value.
> >
> > $ diff -u /usr/obj/pobj/libchdr-1.0pl{20230220,20250608}/fake-amd64/usr/local/include/libchdr/huffman.h
> > --- /usr/obj/pobj/libchdr-1.0pl20230220/fake-amd64/usr/local/include/libchdr/huffman.h  Mon Feb 20 06:24:40 2023
> > +++ /usr/obj/pobj/libchdr-1.0pl20250608/fake-amd64/usr/local/include/libchdr/huffman.h  Wed Dec 11 03:28:49 2024
> > @@ -85,6 +85,6 @@
> >  enum huffman_error huffman_assign_canonical_codes(struct huffman_decoder* decoder);
> >  enum huffman_error huffman_compute_tree_from_histo(struct huffman_decoder* decoder);
> >  
> > -void huffman_build_lookup_table(struct huffman_decoder* decoder);
> > +enum huffman_error huffman_build_lookup_table(struct huffman_decoder* decoder);

honestly I would major bump for that, we don't generally evaluate
whether anything in ports is using an interface which has changed.
and somebody might have compiled something out of ports.

also, except for -stable backports, library bumps are pretty cheap.

> > There are some new symbols so I propose a minor bump.
> >
> >   /usr/obj/pobj/libchdr-1.0pl20230220/fake-amd64/usr/local/lib/libchdr.so.1.0 --> /usr/obj/pobj/libchdr-1.0pl20250608/fake-amd64/usr/local/lib/libchdr.so.1.1
> > Dynamic export changes:
> > added:
> >         chd_read_header_core_file
> >         chd_read_header_file
> >
> > External reference changes:
> > added:
> >         ZSTD_trace_decompress_begin
> >         ZSTD_trace_decompress_end
> >         calloc
> >         puts

btw those "External reference changes" are not new symbols exported by
the library, they are functions from other libraries which are used.
the check_sym script is originally meant for evaluating changes to
libraries in base so it reports things which aren't relevant to ports.