Index | Thread | Search

From:
Josh Grosse <josh@jggimi.net>
Subject:
Re: [new / returning] pokerth 2025.09.04
To:
ports@openbsd.org
Date:
Wed, 17 Sep 2025 15:48:29 -0400

Download raw body.

Thread
On Wed, Sep 17, 2025 at 09:22:19AM -0600, Anthony J. Bentley wrote:

> INSTALL_DEBUG_PACKAGES is a user setting; it should not go into a
> port directly. CONFIGURE_ARGS and DEBUG_PACKAGES should simply be set
> unconditionally, with no .if DEBUG, and users can choose to get debug
> symbols simply by installing the debug package.
> 
> One more thing: the license marker needs updating, it should be AGPLv3+.
 
Thank you, again!  Revised Makefile is in the attached tarball, with the
following changes:

diff --git a/games/pokerth/Makefile b/games/pokerth/Makefile
index 50e3bdb88..2d86cfd26 100644
--- a/games/pokerth/Makefile
+++ b/games/pokerth/Makefile
@@ -8,7 +8,7 @@ CATEGORIES =	games
 
 MAINTAINER =	Josh Grosse <josh@jggimi.net>
 
-# GPLv3
+# AGPLv3
 PERMIT_PACKAGE =	Yes
 
 MODULES =	devel/cmake x11/qt6
@@ -16,11 +16,8 @@ SUBST_VARS +=	MODQT_QTDIR V
 
 ALL_TARGET =	pokerth_client
 
-.if DEBUG
 CONFIGURE_ARGS +=		-DCMAKE_BUILD_TYPE=RelWithDebInfo
 DEBUG_PACKAGES =		${BUILD_PACKAGES}
-INSTALL_DEBUG_PACKAGES =	Yes
-.endif
 
 BUILD_DEPENDS +=	x11/qt6/qtwebsockets