On Sat, Sep 20, 2025 at 08:52:13PM +0200, Rafael Sadowski wrote:
> On Sat Sep 20, 2025 at 06:02:46PM +0200, Antoine Jacoutot wrote:
> > On Sat, Sep 20, 2025 at 02:09:29PM +0200, Rafael Sadowski wrote:
> > > Hi All,
> > > 
> > > Thanks to the excellent work of Joel Knight [1], I would like to
> > > propose importing awscli v2 in addition to v1.
> > > 
> > > The idea is simple. sysutils/awscli will be moved to
> > > sysutils/awscli/v1 and v2 will be added. Both ports will receive
> > > an "@option is-branch".
> > > 
> > > The result is the following:
> > > 
> > > env TRUSTED_PKG_PATH=/usr/ports/packages/amd64/all doas pkg_add awscli
> > > Ambiguous: choose package for awscli
> > > a	0: <None>
> > > 	1: awscli-1.42.35
> > > 	2: awscli-2.28.4
> > > 
> > > Why v2 at all? AWS now only generates v2 key/secret pairs by default.
> > > 
> > > Explaining to someone that they should provide you with v1 keys
> > > because you use OpenBSD is painful and time-consuming. I want to
> > > avoid this.
> > > 
> > > The attachment contains the following structure, including a new
> > > dependency.
> > 
> > - Wouldn't it be simpler to have awscli and awscli2 without putting everything
> > below the same structure?
> 
> Thanks Antoine for the quick feedback.
> 
> I don't think it makes things much easier. Anyone who uses awscli
> in shell scripts will need a symlink at some point. Not ideal
> either. In my opinion, the structure is perfect for "is-branch"
> ports. Everything in one place.
> 
> >   - if not, then you could factorize post-install in Makefile.inc
> 
> Done
> 
> > - MODPY_FLAVOR does not exist anymore
> 
> Removed
> 
> > - MODPY_DISTV? is commented and can be removed
> 
> Removed
> 
> > - shouldn't these ports conflict?
> 
> By default, a package conflicts with other versions of the same
> package as we set NO no-default-conflict.
> 
> > - I am really not a fan to the BUILD_DEPENDS=${RUN_DEPENDS} construct; is
> >   everything needed to run is also really needed for building?
> 
> I can understand you, I deinstalled all py3 packages from
> RUN_DEPENDS and added all needed to build in BUILD_DEPENDS.
> 
> New tarball attached.

You still have FLAVORS in py-awscrt.

Also let's make sure Joel is still OK to maintain these 2 ports.

The rest looks fine to me.


-- 
Antoine