Index | Thread | Search

From:
Antoine Jacoutot <ajacoutot@bsdfrog.org>
Subject:
Re: [update] webkitgtk 2.50.0
To:
Stuart Henderson <stu@spacehopper.org>
Cc:
ports@openbsd.org
Date:
Wed, 24 Sep 2025 17:51:24 +0200

Download raw body.

Thread
On Wed, Sep 24, 2025 at 10:41:28AM +0100, Stuart Henderson wrote:
> i386 fails; errors here, full log attached.
> 
> /pobj/webkitgtk40-2.50.0/bin/c++ <<snip>>  -c /pobj/webkitgtk40-2.50.0/webkitgtk-2.50.0/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp
> /pobj/webkitgtk40-2.50.0/webkitgtk-2.50.0/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:286:9: error: use of undeclared label 'op_instanceof_return_location'
>   286 |         FOR_EACH_BYTECODE_HELPER_ID(OPCODE_ENTRY)
>       |         ^
> /pobj/webkitgtk40-2.50.0/build-i386/JavaScriptCore/DerivedSources/Bytecodes.h:989:11: note: expanded from macro 'FOR_EACH_BYTECODE_HELPER_ID'
>   989 |     macro(op_instanceof_return_location, 0) \
>       |           ^
> /pobj/webkitgtk40-2.50.0/webkitgtk-2.50.0/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:286:37: error: use of undeclared label 'op_instanceof_return_location_wide16'
>   286 |         FOR_EACH_BYTECODE_HELPER_ID(OPCODE_ENTRY)
>       |                                     ^
> /pobj/webkitgtk40-2.50.0/webkitgtk-2.50.0/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:286:37: error: use of undeclared label 'op_instanceof_return_location_wide32'

Could you try adding the attached patch?
Thanks.

-- 
Antoine
Fix build on i386.

Index: Source/JavaScriptCore/llint/LowLevelInterpreter.asm
--- Source/JavaScriptCore/llint/LowLevelInterpreter.asm.orig
+++ Source/JavaScriptCore/llint/LowLevelInterpreter.asm
@@ -2980,6 +2980,13 @@ _wasm_ipint_call_return_location_wide16:
 _wasm_ipint_call_return_location_wide32:
     crash()
 
+if C_LOOP and not JSVALUE64
+_op_instanceof_return_location:
+_op_instanceof_return_location_wide16:
+_op_instanceof_return_location_wide32:
+    crash()
+end
+
 end # WEBASSEMBLY
 
 include? LowLevelInterpreterAdditions