Index | Thread | Search

From:
Chris Billington <emulti@disroot.org>
Subject:
Re: update: sysutils/dmidecode — add -m option, improve docs and portability
To:
Stuart Henderson <stu@spacehopper.org>
Cc:
ports@openbsd.org
Date:
Sun, 12 Oct 2025 17:55:49 +0800

Download raw body.

Thread
On Sun, 12 Oct 2025 09:34:28 +0100
Stuart Henderson <stu@spacehopper.org> wrote:

> On 2025/10/12 16:25, Chris Billington wrote:
> > The use of uint64_t for the base address was because the SMBIOS
> > specification [2] defines the start address as 64-bit (p24 on the
> > version referenced).
> 
> wouldn't it make more sense to use the existing u64 type used in
> other parts of dmidecode? (obviously that's not OpenBSD's style, but
> when patching for a port, usually better to follow upstream style).
> 
> > I'll get in touch with dmidecode upstream and see if any of these
> > patches can be accepted by them, and keep the list informed.
> 
> thanks.

Makes sense, but just after 3.6 was released upstream have changed the
handling of u64 as in this commit:

https://cgit.git.savannah.gnu.org/cgit/dmidecode.git/commit/?id=2fa4ab1a1d37303b81e701d7ed08ae70965ab96c

I'm trying to figure out what that all means and see if I can apply
patches to their head code.

-- 
Chris Billington