Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: update: ncspot to 1.3.1
To:
David Leadbeater <dgl@dgl.cx>
Cc:
ports@openbsd.org
Date:
Thu, 23 Oct 2025 08:45:09 +0200

Download raw body.

Thread
On Thu, Oct 23, 2025 at 04:14:36PM +1100, David Leadbeater wrote:
> Here is an update to 1.3.1. It also removes the need for USE_NOBTCFI,
> USE_NOEXECONLY, cmake and libclang, because it no longer depends on aws-lc-rs
> (although this wass via a long dependency tree, so possible a future update
> could bring it back, but it's not intended to be there per ncspot commit
> ce300fb7).
> 
> Tested on 7.8-current on amd64.

Most welcome simplification, thanks!

I committed it with a few minor tweaks:

>  GH_ACCOUNT =		hrkfdn
>  GH_PROJECT =		ncspot
> -GH_TAGNAME =		v1.2.1
> +GH_TAGNAME =		v1.3.1
>  REVISION =		1

REVISION should be removed when the version changes (it keeps track
of changes to the package when there is no version change: it starts
empty and is increased to 0, 1, etc until the next version crank).

>  
>  CATEGORIES =		audio
> @@ -25,16 +20,9 @@ WANTLIB +=		${MODCARGO_WANTLIB} crypto curses dbus-1 m portaudio ssl
>  MODULES =		devel/cargo \
>  			lang/clang

the lang/clang module is no longer needed and dropping it removes a
heavy build dependency (clang from ports).

> @@ -47,9 +35,6 @@ MODCARGO_FEATURES =	cursive/termion-backend \
>  
>  .include "crates.inc"

moved that to the more usual place at the end of the file

> -post-patch:
> -	cp ${FILESDIR}/cpu_aarch64_openbsd.c ${MODCARGO_VENDOR_DIR}/aws-lc-sys-0.22.0/aws-lc/crypto/fipsmodule/cpucap/
> -

cpu_aarch64_openbsd.c is no longer needed and could also be removed.