Download raw body.
Fixed gcc PROPERTIES detection
These GCC49_ARCHS are "archs where ports-gcc >4.9 exists". GCC4_ARCHS is a
totally different thing, "archs where the compiler in base is gcc 4", the
two are not interchangeable.
freebasic: I don't see why this is conditional, the port only builds on
ports-gcc archs. "XXX only pulls this if it actually exists" doesn't make
much sense. The various gcc4.port.mk files should have a MODGCC4_CDEP or
similar (similar to MODGCC4_CPPDEP) that ports can use so they don't need
to hardcode versions (as in the RUN_DEPENDS) and then free basic can use that.
numpy: I don't think that needs to be conditional either?
--
Sent from a phone, apologies for poor formatting.
On 25 October 2025 09:05:58 Rafael Sadowski <rafael@sizeofvoid.org> wrote:
> There is nothing comparable to gcc49 anymore. Is it OK to
> replace it with gcc4?
>
> Rafael
>
> diff --git a/lang/freebasic/Makefile b/lang/freebasic/Makefile
> index 8b0f979cfc9..bbf869541f8 100644
> --- a/lang/freebasic/Makefile
> +++ b/lang/freebasic/Makefile
> @@ -33,7 +33,7 @@ BUILD_DEPENDS = devel/libffi
>
> # XXX only pulls this if it actually exists
> .include <bsd.port.arch.mk>
> -.if ${PROPERTIES:Mgcc49}
> +.if ${PROPERTIES:Mgcc4}
> # Use ports-gcc as the backend runtime compiler, since we know FreeBASIC
> # will generate C files with GNU C extensions that clang doesn't like.
> RUN_DEPENDS = devel/libffi \
> diff --git a/math/py-numpy/Makefile b/math/py-numpy/Makefile
> index 9d2df7f7c9f..99ee8a1b38b 100644
> --- a/math/py-numpy/Makefile
> +++ b/math/py-numpy/Makefile
> @@ -48,7 +48,7 @@ TEST_DEPENDS= ${FULLPKGNAME}:${FULLPKGPATH} \
> devel/py-wheel
>
> .include <bsd.port.arch.mk>
> -.if ${PROPERTIES:Mgcc49}
> +.if ${PROPERTIES:Mgcc4}
> MODULES+= fortran
> BUILD_DEPENDS+= ${MODFORTRAN_BUILD_DEPENDS}
> LIB_DEPENDS+= ${MODFORTRAN_LIB_DEPENDS} \
Fixed gcc PROPERTIES detection