30.10.2025 21:48, Stuart Henderson пишет:
> ok I guess.

Thanks, will go ahead in a day or two unless there's more feedback.

>> Funnily, the code knows that:
>>
>> 	 * Modifies the string pointed to by spec in-place due to the use of
>> 		  * strtok(3). The caller should strdup(3) or otherwise copy the string
>> 	 * if an unmodified copy is needed.
> 
> suppose that comment should be removed too?
Well, it is relevant, no?

I'd say perhaps upstream, but in the port it's just churn.

> seems worth trying it upstream and see if they'll take it?

Sent via https://github.com/esnet/iperf/pull/1960