Index | Thread | Search

From:
Kristaps Dzonsons <kristaps@bsd.lv>
Subject:
Re: subsurface - disable the built-in facebook, user manual and printing support
To:
Rafael Sadowski <rafael@sizeofvoid.org>, The OpenBSD ports mailing-list <ports@openbsd.org>
Date:
Thu, 30 Oct 2025 21:08:14 -0700

Download raw body.

Thread
Hi all,

I can confirm that this works perfectly with a small change:

> +CONFIGURE_ARGS +=	-DNO_DOCS=ON \
> +			-DUSE_WEBENGINE=OFF \
> +			-DFBSUPPORT=OFF \
> +			-DBTSUPPORT=OFF \
> +			-DNO_PRINTING=ON \
> +			-DNO_USERMANUAL=ON

The NO_DOCS, FBSUPPORT, and USE_WEBENGINE are not necessary: the first 
two do not exist and the last is implied by no printing or usermanual. 
I've attached a patch (following yours) that has those removed.

> +
> +CONFIGURE_ARGS +=	-DLIBGIT2_FROM_PKGCONFIG=ON
>   CONFIGURE_ARGS +=	-DWRKINST=${WRKINST}
> -CONFIGURE_ARGS +=       -DUSE_WEBENGINE:Bool=OFF
> -CONFIGURE_ARGS +=       -DNO_PRINTING:Bool=ON
>   
>   # It's possible to run the tests, but they fail.
>   # First, add the subsurface/large-anonymous-sample-data repo to DISTFILES.

Thank you again Rafael and Stuart!  This tool is so useful to me--I 
really appreciate your help.

Best,

Kristaps
Index: Makefile
===================================================================
RCS file: /cvs/ports/misc/subsurface/Makefile,v
diff -u -p -r1.19 Makefile
--- Makefile	27 Oct 2025 11:13:50 -0000	1.19
+++ Makefile	31 Oct 2025 03:43:53 -0000
@@ -11,15 +11,11 @@ HOMEPAGE =	https://subsurface-divelog.or
 # GPLv2, LGPLv2.1 for libdivecomputer, MIT for googlemaps
 PERMIT_PACKAGE =	Yes
 
-WANTLIB += ${COMPILER_LIBCXX}
-WANTLIB += GL Qt5Concurrent Qt5Core Qt5Gui Qt5Location Qt5Network
-WANTLIB += Qt5Positioning Qt5PositioningQuick Qt5Qml Qt5QmlModels
-WANTLIB += Qt5Quick Qt5QuickWidgets Qt5Svg Qt5Widgets c crypto
-WANTLIB += git2 lcms2 m raw_r sqlite3 ssh2 ssl usb-1.0 xml2 xslt
-WANTLIB += zip
-
-# presumably dlopen()'d?
-WANTLIB += Qt5WebKit Qt5WebKitWidgets
+WANTLIB += ${COMPILER_LIBCXX} GL Qt5Concurrent Qt5Core Qt5Gui
+WANTLIB += Qt5Location Qt5Network Qt5Positioning Qt5PositioningQuick
+WANTLIB += Qt5Qml Qt5QmlModels Qt5Quick Qt5QuickWidgets Qt5Svg
+WANTLIB += Qt5Widgets c crypto git2 lcms2 m mtp raw_r sqlite3
+WANTLIB += ssh2 ssl usb-1.0 xml2 xslt zip
 
 USE_GMAKE =	Yes
 
@@ -40,6 +36,7 @@ LIB_DEPENDS =	archivers/libzip \
 		databases/sqlite3 \
 		devel/libgit2/libgit2 \
 		devel/libusb1 \
+		devel/libmtp \
 		graphics/lcms2 \
 		graphics/libraw \
 		security/libssh2 \
@@ -49,18 +46,19 @@ LIB_DEPENDS =	archivers/libzip \
 		x11/qt5/qtdeclarative \
 		x11/qt5/qtlocation \
 		x11/qt5/qtsvg \
-		x11/qt5/qtwebkit \
 		x11/qt5/qtlocation
 
 RUN_DEPENDS =	devel/desktop-file-utils \
 		x11/gtk+4,-guic
 
-CONFIGURE_ARGS +=	-DBTSUPPORT:Bool=OFF
-CONFIGURE_ARGS +=	-DLIBGIT2_FROM_PKGCONFIG:Bool=ON
-CONFIGURE_ARGS +=	-DNO_USERMANUAL:Bool=ON
+# Disable the built-in facebook, user manual and printing support which require
+# qt5-webkit/qt5-webengine
+CONFIGURE_ARGS +=	-DBTSUPPORT=OFF \
+			-DNO_PRINTING=ON \
+			-DNO_USERMANUAL=ON
+
+CONFIGURE_ARGS +=	-DLIBGIT2_FROM_PKGCONFIG=ON
 CONFIGURE_ARGS +=	-DWRKINST=${WRKINST}
-CONFIGURE_ARGS +=       -DUSE_WEBENGINE:Bool=OFF
-CONFIGURE_ARGS +=       -DNO_PRINTING:Bool=ON
 
 # It's possible to run the tests, but they fail.
 # First, add the subsurface/large-anonymous-sample-data repo to DISTFILES.