On 2025/11/01 17:45, Stuart Henderson wrote:
> On 2025/11/01 16:59, Frank Solli wrote:
> > Sorry about the link, my client must have done something funky, I want to have it included in the ports tree. Attaching the file here On Nov 1, 2025, at 5:55 PM, Jeremie Courreges-Anglas <jca@wxcvbn.org> wrote: On Sat, Nov 01, 2025 at 04:48:07PM +0000, Frank Solli wrote: Hi, my first port for OpenBSD, Would be nice to have some input on it, it can be found here: GitHub - fr0x41nk/openbsd-ports-hitch github.com If you want to point people at a some website, just give them the URL. But here you're looking for input on a new port, and you're not saying whether you want to submit it for inclusion in the ports tree. If so, reviews are done on this mailing-list, not on github, and for new ports you should provide a tarball of the port directory. -- jca
> 
> in general (and definitely for OpenBSD related things), please use
> plaintext emails when sending to mailing lists. html mails are likely
> to be mangled terribly.
> 

...reading through the port you have some unnecessary complications by
using the github development source rather than a proper release
tarball; in particular build deps on bison, py-docutils etc to
generate formatted files (docs etc) from source files, those
formatted files are normally distributed in the tar.

enable-warnings uses "--Werror" which is not good for ports.

also patches should be generated using "make update-patches".

...but then I realised this was previously in ports, so probably better
to base it on that. I've attached a tgz which is a merge of your port,
the old security/hitch, and a few tweaks. Some of the tests fail,
I haven't looked into that. I have no idea whether SSL_CTX_set1_cert_store
is a suitable replacement for SSL_CTX_set1_verify_cert_store in the
patch.

(also needs the old uid uncommenting in infrastructure/db/user.list).

• hitch.tgz (4K)