Index | Thread | Search

From:
Maximo Pech <makzpj@gmail.com>
Subject:
Re: [Update] x11/picom 12.5
To:
OpenBSD Ports <ports@openbsd.org>
Date:
Tue, 4 Nov 2025 08:41:00 -0600

Download raw body.

Thread
Hello, I've made changes according to the feedback received, attaching
the diff file.

El vie, 31 oct 2025 a las 12:48, Stuart Henderson
(<stu@spacehopper.org>) escribió:
>
> On 2025/10/31 12:13, Maximo Pech wrote:
> > Hi ports,
> >
> > This is an update for x11/picom to version 12.5, I've tested it for
> > several days already with no issues.
> >
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/x11/picom/Makefile,v
> > retrieving revision 1.13
> > diff -u -p -u -r1.13 Makefile
> > --- Makefile 25 Jul 2025 14:46:35 -0000 1.13
> > +++ Makefile 31 Oct 2025 18:05:09 -0000
>
> Your diff is mangled (whitespace and word wrap issues), if you can't use
> an MUA that doesn't do this it will probably be better if you send as an
> attachment
>
> > @@ -1,6 +1,6 @@
> >  COMMENT = lightweight compositor for X11
> >
> > -DIST_TUPLE = github yshui picom v11.2 .
> > +DIST_TUPLE = github yshui picom v12.5 .
> >  REVISION = 0
>
> drop REVISION when updating
>
> >  CATEGORIES = x11
> > @@ -20,7 +20,7 @@ COMPILER = base-clang ports-gcc
> >  COMPILER_LANGS = c
> >
> >  BUILD_DEPENDS = devel/uthash \
> > - textproc/asciidoc
> > + textproc/asciidoctor
> >
> >  RUN_DEPENDS = x11/gtk+4,-guic \
> >   devel/desktop-file-utils
> > Index: distinfo
> > ===================================================================
> > RCS file: /cvs/ports/x11/picom/distinfo,v
> > retrieving revision 1.8
> > diff -u -p -u -r1.8 distinfo
> > --- distinfo 27 Feb 2024 22:49:57 -0000 1.8
> > +++ distinfo 31 Oct 2025 18:05:09 -0000
> > @@ -1,2 +1,2 @@
> > -SHA256 (yshui-picom-v11.2.tar.gz) =
> > HBBjk2+vCe2bunJudzelYlZLel+M3vedSPza82aaTfQ=
> > -SIZE (yshui-picom-v11.2.tar.gz) = 308679
> > +SHA256 (yshui-picom-v12.5.tar.gz) =
> > Yn+l18WQ3zuo0sQes104WfeCa9KPpJ6SoOBPtg7XeQQ=
> > +SIZE (yshui-picom-v12.5.tar.gz) = 674165
> > Index: patches/patch-meson_build
> > ===================================================================
> > RCS file: /cvs/ports/x11/picom/patches/patch-meson_build,v
> > retrieving revision 1.3
> > diff -u -p -u -r1.3 patch-meson_build
> > --- patches/patch-meson_build 22 Nov 2022 16:07:27 -0000 1.3
> > +++ patches/patch-meson_build 31 Oct 2025 18:05:09 -0000
> > @@ -1,24 +1,20 @@
> > -- ignore git
> > -- autostart file in /etc/ needs PLIST @sample
>
> don't remove the comments
>
> > -
> >  Index: meson.build
> >  --- meson.build.orig
> >  +++ meson.build
> > -@@ -7,8 +7,7 @@ cc = meson.get_compiler('c')
> > - version = 'v'+meson.project_version()
> > +@@ -5,7 +5,7 @@ cc = meson.get_compiler('c')
> >
> >   # use git describe if that's available
> > --git = find_program('git', required: false)
> > + git = find_program('git', required: false)
>
> why drop this part of the patch?
>
> >  -if git.found()
> > -+if false
> > - gitv = run_command('git', 'rev-parse', '--short=5', 'HEAD', check: false)
> > ++if false
> > + gitv = run_command('git', 'rev-parse', '--short=7', 'HEAD', check: false)
> >   if gitv.returncode() == 0
> > - version = 'vgit-'+gitv.stdout().strip()
> > -@@ -73,7 +72,6 @@ subdir('man')
> > + commit_hash_short = gitv.stdout().strip()
> > +@@ -110,7 +110,6 @@ subdir('tools')
> >
> >   install_data('bin/picom-trans', install_dir: get_option('bindir'))
> >   install_data('picom.desktop', install_dir: 'share/applications')
> >  -install_data('picom.desktop', install_dir: get_option('sysconfdir')
> > / 'xdg' / 'autostart')
> >
> > - if get_option('compton')
> > - install_data('compton.desktop', install_dir: 'share/applications')
> > + pkgconf = import('pkgconfig')
> > +
> > Index: pkg/PLIST
> > ===================================================================
> > RCS file: /cvs/ports/x11/picom/pkg/PLIST,v
> > retrieving revision 1.4
> > diff -u -p -u -r1.4 PLIST
> > --- pkg/PLIST 22 Nov 2022 16:07:28 -0000 1.4
> > +++ pkg/PLIST 31 Oct 2025 18:05:09 -0000
> > @@ -1,5 +1,8 @@
> >  @bin bin/picom
> > +bin/picom-inspect
> >  bin/picom-trans
> > +lib/pkgconfig/picom-api.pc
> > +@man man/man1/picom-inspect.1
> >  @man man/man1/picom-trans.1
> >  @man man/man1/picom.1
> >  share/applications/picom.desktop
> >