Index | Thread | Search

From:
Claudio Jeker <cjeker@diehard.n-r-g.com>
Subject:
libnotify, fix compile with gcc4
To:
Antoine Jacoutot <ajacoutot@openbsd.org>
Cc:
ports@openbsd.org
Date:
Thu, 6 Nov 2025 13:15:37 +0100

Download raw body.

Thread
In libnotify the function
notification_app_launch_context_get_startup_notify_id()
lacks parameter names for the unused arguments. gcc4 really dislikes that.

With this libnotify builds and unlocks a fair amount of the ports tree.
-- 
:wq Claudio

Index: patches/patch-libnotify_launch-context_c
===================================================================
RCS file: patches/patch-libnotify_launch-context_c
diff -N patches/patch-libnotify_launch-context_c
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ patches/patch-libnotify_launch-context_c	6 Nov 2025 10:37:44 -0000
@@ -0,0 +1,16 @@
+launch-context.c:52: error: parameter name omitted
+
+Index: libnotify/launch-context.c
+--- libnotify/launch-context.c.orig
++++ libnotify/launch-context.c
+@@ -49,8 +49,8 @@ notification_app_launch_context_finalize (GObject *obj
+ 
+ static char *
+ notification_app_launch_context_get_startup_notify_id (GAppLaunchContext *context,
+-                                                       GAppInfo *,
+-                                                       GList *)
++                                                       GAppInfo *info,
++                                                       GList *list)
+ {
+         NotificationAppLaunchContext *self = NOTIFICATION_APP_LAUNCH_CONTEXT (context);
+