Index | Thread | Search

From:
Stuart Henderson <stu@spacehopper.org>
Subject:
Re: pkg_create: @lib without LIBname_VERSION
To:
Marc Espie <marc.espie.openbsd@gmail.com>, George Koehler <kernigh@gmail.com>
Cc:
<ports@openbsd.org>
Date:
Wed, 12 Nov 2025 10:55:16 +0000

Download raw body.

Thread
I'd appreciate leaving the python libname craziness as-is until 3.13 is in :)

-- 
  Sent from a phone, apologies for poor formatting.

On 12 November 2025 10:09:42 Marc Espie <marc.espie.openbsd@gmail.com> wrote:

> On Mon, Nov 10, 2025 at 02:47:05PM -0500, George Koehler wrote:
>> On Sat, 8 Nov 2025 17:48:22 +0100
>> Marc Espie <marc.espie.openbsd@gmail.com> wrote:
>>
>> > If you wonder whether it should be @so's with no version at all or @lib
>> > libraries, that's a secondary concern, imo. Make sure everything
>> > that says "@lib" has a corresponding SHARED_LIBS, then you can
>> > decide what you want to do.
>>
>> This diff checks that each @lib has a LIBname_VERSION, but doesn't
>> look for '${LIBname_VERSION}'.  This works with all ports but
>> devel/qcad when I tried "make print-plist-all >/dev/null".  It works
>> with devel/libtalloc where make(1) expands a version variable before
>> pkg_create(1) can see it,
>>
>> devel/libtalloc/Makefile:
>> PYTALLOC_UTIL_LIBSUFFIX=	cpython-${MODPY_MAJORMINOR}.so.${LIBpytalloc-util.cpython-${MODPY_MAJORMINOR}_VERSION}
>> devel/libtalloc/pkg/PLIST-python:
>> @lib lib/libpytalloc-util.${PYTALLOC_UTIL_LIBSUFFIX}
>
>
> I don't see why libtalloc has to be special
>
> There's nothing that prevents SHARED_LIBS from using more variables
> and you from defining stuff that makes sure pkg_create will see the
> right thing.