Index | Thread | Search

From:
Landry Breuil <landry@openbsd.org>
Subject:
Re: multimedia/handbrake: update to 1.10.2
To:
ports@openbsd.org
Date:
Wed, 12 Nov 2025 18:45:35 +0100

Download raw body.

Thread
Le Wed, Nov 12, 2025 at 06:37:47PM +0100, Landry Breuil a écrit :
> Le Wed, Nov 12, 2025 at 05:15:09PM +0100, Kirill A. Korinsky a écrit :
> > ports@,
> > 
> > I'd like to update multimedia/handbrake to 1.10.2
> > 
> > I had started with clean patches folders.
> > 
> > It builds, I had encoded a short test video.
> > 
> > Anyway, any tests are welcomes, and OKs.
> 
> I know this port has CONFIGURE_STYLE=simple, but...
> 
> > @@ -40,6 +39,8 @@ BUILD_DEPENDS =	devel/autoconf/${AUTOCON
> >  		devel/automake/${AUTOMAKE_VERSION} \
> >  		devel/gettext,-tools \
> >  		devel/libtool \
> > +		devel/meson \
> > +		devel/ninja \
> 
> This feels... wrong.
> 
> can't we somehow make it directly use the meson module with
> gtk/meson.build, instead of their homegrown horror of make/configure.py ?

bah, it first tries to build libghb (aptly naming ...) so it doesn't use
meson all the way it seems.

also, fails to build, wrong ffmpeg api ? missing patch ?

/usr/obj/ports/handbrake-1.10.2/HandBrake-1.10.2/libhb/encsvtav1.c:102:71: error: too few arguments to function call, expected 3, have 2
  102 |     svt_ret = svt_av1_enc_init_handle(&pv->svt_handle, &pv->enc_params);
      |               ~~~~~~~~~~~~~~~~~~~~~~~                                 ^
/usr/local/include/svt-av1/EbSvtAv1Enc.h:1012:20: note: 'svt_av1_enc_init_handle' declared here
 1012 | EB_API EbErrorType svt_av1_enc_init_handle(
      |                    ^
 1013 |     EbComponentType **p_handle, void *p_app_data,
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1014 |     EbSvtAv1EncConfiguration *config_ptr); // config_ptr will be loaded with default params from the library
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/obj/ports/handbrake-1.10.2/HandBrake-1.10.2/libhb/encsvtav1.c:505:41: error: use of undeclared identifier 'AV_FRAME_DATA_DOVI_RPU_BUFFER_T35'; did you mean 'AV_FRAME_DATA_DOVI_RPU_BUFFER'?
  505 |                      side_data->type == AV_FRAME_DATA_DOVI_RPU_BUFFER_T35)
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                         AV_FRAME_DATA_DOVI_RPU_BUFFER
/usr/local/include/libavutil/frame.h:201:5: note: 'AV_FRAME_DATA_DOVI_RPU_BUFFER' declared here
  201 |     AV_FRAME_DATA_DOVI_RPU_BUFFER,


>