On 2025/11/22 21:27, Christoph Liebender wrote:
> On 11/22/25 20:56, Stuart Henderson wrote:
> > On 2025/11/22 18:46, Klemens Nanni wrote:
> > > 22.11.2025 16:03, Christoph Liebender пишет:
> > > > ok to apply patch to bump openmdns to 0.8?
> > > > portcheck and make port-lib-depends-check are happy.
> > > > Runs fine.
> > > A git diff with renames won't apply through patch.
> > 
> > git diff --no-renames
> 
> Thanks Stuart! The --no-renames patch is attached.
> 
> > 
> > > Please inline not attach the diff.
> > > 
> 
> Last time I did that, the patch did not apply, and somebody suggested to
> attach the diff instead. I guess I have to come out at this point as a

inline is preferred if you can do so in such a way that it doesn't get
mangled.

if not then attachment is better than mangled.

> thunderbird user and I have no clue how to submit patches such that everyone
> is satisfied.

some people use an alternative MUA to send diffs if their preferred one
is unable to do this cleanly.

> Another note; the produced package contains libmdns.a static libraries that
> are probably not useful in any way, at least without the headers installed
> as well. I wonder, does it make sense to ship them at all? If not, what is
> the best way to remove them? post-build: rm ...*.a ? Or is there a more
> elegant way with MAKE_FLAGS?

i'd just @comment them in this case

> +SHARED_LIBS +=		mdns 0.1

start at 0.0

normally this goes higher, above CATEGORIES

the distfile isn't present at the first SITES entry, so drop that.
the second SITES entry redirects so would be better to replace that.
i.e.

SITES=	https://x61.sh/mirrors/openmdns/

also HOMEPAGE can switch to https.

> index 00000000000..ab65cc99126
> --- /dev/null
> +++ b/net/openmdns/patches/patch-libmdns_mdnsl_c

would be better with comments in the patches showing where they're from
and what they're for