Index | Thread | Search

From:
Rafael Sadowski <rafael@sizeofvoid.org>
Subject:
Re: devel/binutils: require same gas version
To:
Klemens Nanni <kn@openbsd.org>
Cc:
ports <ports@openbsd.org>, Frederic Cambus <fcambus@openbsd.org>
Date:
Thu, 27 Nov 2025 17:06:31 +0100

Download raw body.

Thread
On Thu Nov 27, 2025 at 03:53:42PM +0000, Klemens Nanni wrote:
> To do what the comment suggests, otherwise you might end up with
> 2.45.1 binutils and 2.45 gas, for example.
> 
> I did not run into problems, but carrying a local binutils diff
> across the .1 update made me notice that the dependency did not
> get dragged along.
> 
> Thoughts?

Better than the current situation. If someone has forgotten to
update devel/gas with the same version, an error occurs, which is
a good quality gate.

OK rsadowski but please wait for maintianer feedback or timeout.

> 
> diff --git a/devel/binutils/Makefile b/devel/binutils/Makefile
> index dee91052913..9f5bd2eff91 100644
> --- a/devel/binutils/Makefile
> +++ b/devel/binutils/Makefile
> @@ -1,7 +1,9 @@
>  COMMENT =	GNU binary utilities
>  
>  # keep version synchronized with devel/gas
> -DISTNAME =	binutils-2.45.1
> +V =		2.45.1
> +DISTNAME =	binutils-${V}
> +REVISION =	0
>  EXTRACT_SUFX =	.tar.bz2
>  
>  CATEGORIES =	devel
> @@ -19,7 +21,7 @@ COMPILER_LANGS =	c
>  WANTLIB += c z zstd
>  
>  LIB_DEPENDS +=	archivers/zstd
> -RUN_DEPENDS +=	devel/gas>=2.45p1
> +RUN_DEPENDS +=	devel/gas>=${V}
>  
>  SITES =		${SITE_GNU:=binutils/}
>  
>