Index | Thread | Search

From:
Peter Hessler <phessler@theapt.org>
Subject:
Re: more -Wimplicit-int fixes
To:
ports@openbsd.org, Edd Barrett <edd@openbsd.org>, Peter Hessler <phessler@openbsd.org>, Stuart Cassoff <stwo@users.sourceforge.net>
Date:
Mon, 15 Dec 2025 15:11:29 +0100

Download raw body.

Thread
OK

On 2025 Dec 15 (Mon) at 15:05:32 +0100 (+0100), Claudio Jeker wrote:
:Another round of fixing various code that depends on C semantics long
:gone.
:
:Some of it is in just the configure scripts but there is a fair share of
:not so good code :)
:
:-- 
::wq Claudio
:
:
:Index: games/clonekeen/patches/patch-src_misc_ui_c
:===================================================================
:RCS file: /cvs/ports/games/clonekeen/patches/patch-src_misc_ui_c,v
:diff -u -p -r1.2 patch-src_misc_ui_c
:--- games/clonekeen/patches/patch-src_misc_ui_c	11 Mar 2022 19:04:12 -0000	1.2
:+++ games/clonekeen/patches/patch-src_misc_ui_c	15 Dec 2025 12:53:30 -0000
:@@ -10,3 +10,12 @@ Index: src/misc_ui.c
:  
:  // pops up a message (used by youseeinyourmind and VorticonElder)
:  int twirly_timer, twirly_frame, twirl_x=-1, twirl_y=-1;
:+@@ -133,7 +133,7 @@ void ShipEp3(void)
:+ {
:+ char msgname[20];
:+ uchar pick;
:+-static lastpick = -1;
:++static int lastpick = -1;
:+ 	
:+ 	// display one of four random strings
:+ 	do { pick = (rnd()%4)+1; } while(pick == lastpick);
:Index: games/maelstrom/patches/patch-Maelstrom-netd_c
:===================================================================
:RCS file: /cvs/ports/games/maelstrom/patches/patch-Maelstrom-netd_c,v
:diff -u -p -r1.2 patch-Maelstrom-netd_c
:--- games/maelstrom/patches/patch-Maelstrom-netd_c	11 Mar 2022 19:04:38 -0000	1.2
:+++ games/maelstrom/patches/patch-Maelstrom-netd_c	15 Dec 2025 12:53:30 -0000
:@@ -14,3 +14,12 @@ Index: Maelstrom-netd.c
:  #include <unistd.h>
:  
:  /* We wait in a loop for players to connect and tell us how many people
:+@@ -181,7 +183,7 @@ void I_Crashed(int sig)
:+ 	exit(sig);
:+ }
:+ 
:+-main(int argc, char *argv[])
:++int main(int argc, char *argv[])
:+ {
:+ 	int netfd, i, slot;
:+ 	struct sockaddr_in serv_addr;
:Index: games/oilwar/patches/patch-configure
:===================================================================
:RCS file: games/oilwar/patches/patch-configure
:diff -N games/oilwar/patches/patch-configure
:--- /dev/null	1 Jan 1970 00:00:00 -0000
:+++ games/oilwar/patches/patch-configure	15 Dec 2025 12:53:30 -0000
:@@ -0,0 +1,12 @@
:+Index: configure
:+--- configure.orig
:++++ configure
:+@@ -1036,7 +1036,7 @@ cat > conftest.$ac_ext << EOF
:+ #line 1037 "configure"
:+ #include "confdefs.h"
:+ 
:+-main(){return(0);}
:++int main(void){return(0);}
:+ EOF
:+ if { (eval echo configure:1042: \"$ac_link\") 1>&5; (eval $ac_link) 2>&5; } && test -s conftest${ac_exeext}; then
:+   ac_cv_prog_cc_works=yes
:Index: math/prover9/ladr/patches/patch-mace4_src_msearch_c
:===================================================================
:RCS file: math/prover9/ladr/patches/patch-mace4_src_msearch_c
:diff -N math/prover9/ladr/patches/patch-mace4_src_msearch_c
:--- /dev/null	1 Jan 1970 00:00:00 -0000
:+++ math/prover9/ladr/patches/patch-mace4_src_msearch_c	15 Dec 2025 12:53:30 -0000
:@@ -0,0 +1,12 @@
:+Index: mace4.src/msearch.c
:+--- mace4.src/msearch.c.orig
:++++ mace4.src/msearch.c
:+@@ -812,7 +812,7 @@ BOOL iterate_ok(int n, char *class)
:+  *************/
:+ 
:+ static
:+-int next_domain_size(n)
:++int next_domain_size(int n)
:+ {
:+   int top = (parm(Opt->end_size) == -1 ? INT_MAX : parm(Opt->end_size));
:+       
:Index: math/prover9/ladr/patches/patch-mace4_src_select_c
:===================================================================
:RCS file: math/prover9/ladr/patches/patch-mace4_src_select_c
:diff -N math/prover9/ladr/patches/patch-mace4_src_select_c
:--- /dev/null	1 Jan 1970 00:00:00 -0000
:+++ math/prover9/ladr/patches/patch-mace4_src_select_c	15 Dec 2025 12:53:30 -0000
:@@ -0,0 +1,12 @@
:+Index: mace4.src/select.c
:+--- mace4.src/select.c.orig
:++++ mace4.src/select.c
:+@@ -232,7 +232,7 @@ int select_concentric(void)
:+  *
:+  *************/
:+ 
:+-int select_concentric_band(max_constrained)
:++int select_concentric_band(int max_constrained)
:+ {
:+   int max = -1;
:+   int id_of_max = -1;
:Index: net/ns/patches/patch-configure_in
:===================================================================
:RCS file: net/ns/patches/patch-configure_in
:diff -N net/ns/patches/patch-configure_in
:--- /dev/null	1 Jan 1970 00:00:00 -0000
:+++ net/ns/patches/patch-configure_in	15 Dec 2025 12:53:37 -0000
:@@ -0,0 +1,12 @@
:+Index: configure.in
:+--- configure.in.orig
:++++ configure.in
:+@@ -52,7 +52,7 @@ touch confdefs.h
:+ AC_TRY_RUN([#include <stdlib.h>
:+ #include "confdefs.h"
:+ long random() { return 1; }
:+-main() { exit(0); }
:++int main(void) { exit(0); }
:+ ],
:+ AC_MSG_RESULT(long)
:+ AC_DEFINE(RANDOM_RETURN_TYPE,long)
:Index: textproc/isearch/patches/patch-configure
:===================================================================
:RCS file: textproc/isearch/patches/patch-configure
:diff -N textproc/isearch/patches/patch-configure
:--- /dev/null	1 Jan 1970 00:00:00 -0000
:+++ textproc/isearch/patches/patch-configure	15 Dec 2025 12:53:37 -0000
:@@ -0,0 +1,48 @@
:+Index: configure
:+--- configure.orig
:++++ configure
:+@@ -634,7 +634,7 @@ else
:+ cat > conftest.$ac_ext <<EOF
:+ #line 636 "configure"
:+ #include "confdefs.h"
:+-main(){return(0);}
:++int main(void){return(0);}
:+ EOF
:+ eval $ac_link
:+ if test -s conftest && (./conftest; exit) 2>/dev/null; then
:+@@ -660,7 +660,7 @@ cat > conftest.$ac_ext <<EOF
:+ #line 661 "configure"
:+ #include "confdefs.h"
:+ #include <stdio.h>
:+-main()
:++int main(void)
:+ {
:+   FILE *f=fopen("conftestval", "w");
:+   if (!f) exit(1);
:+@@ -694,7 +694,7 @@ cat > conftest.$ac_ext <<EOF
:+ #line 695 "configure"
:+ #include "confdefs.h"
:+ #include <stdio.h>
:+-main()
:++int main(void)
:+ {
:+   FILE *f=fopen("conftestval", "w");
:+   if (!f) exit(1);
:+@@ -728,7 +728,7 @@ cat > conftest.$ac_ext <<EOF
:+ #line 729 "configure"
:+ #include "confdefs.h"
:+ #include <stdio.h>
:+-main()
:++int main(void)
:+ {
:+   FILE *f=fopen("conftestval", "w");
:+   if (!f) exit(1);
:+@@ -762,7 +762,7 @@ cat > conftest.$ac_ext <<EOF
:+ #line 763 "configure"
:+ #include "confdefs.h"
:+ #include <stdio.h>
:+-main()
:++int main(void)
:+ {
:+   FILE *f=fopen("conftestval", "w");
:+   if (!f) exit(1);

-- 
Software, n.:
	Formal evening attire for female computer analysts.