Index | Thread | Search

From:
Klemens Nanni <kn@openbsd.org>
Subject:
Re: NEW: devel/kdbindings x11/kddockwidgets
To:
Rafael Sadowski <rafael@sizeofvoid.org>, ports@openbsd.org
Date:
Wed, 07 Jan 2026 03:16:44 +0000

Download raw body.

Thread
27.12.2025 22:18, Rafael Sadowski пишет:
> On Mon Dec 22, 2025 at 10:10:11AM +0100, Rafael Sadowski wrote:
>> On Sat Dec 20, 2025 at 01:48:06PM +0000, yaydn@protonmail.com wrote:
>>> På lørdag 20. desember 2025 kl. 07:09, skrev Rafael Sadowski
>>> <rafael@sizeofvoid.org>:
>>>
>>>>
>>>>
>>>> I would like to import kdbindings-1.1.0 and kddockwidgets-2.4.0 as
>>>> a new dependency for the upcoming kdenlive-25.12 update.
>>>>
>>>> I will add me as a maintainer, OK to import?
>>>>
>>>
>>> I tested this on amd64.
>>>
>>> cd /usr/ports/x11/kddockwidgets/ && make test install clean && make
>>> distclean
>>>
>>> The formatting for Makefile's and DESCR's looks fine, don't see any
>>> nitpicks or style issues, and the packages build and install fine.
>>> kdbindings passed 5/5 tests while kddockwidgets had zero tests to be
>>> had. Overall I'd say ship it.
>>>
>>> Unsure if extra testing helps… But, regardless, thank you for the big
>>> updates to qt6 dependent packages, plasma, and now the upcoming KDE Gear
>>> 25.12!
>>>
>>> Have a good one and a merry time porting.
>>>
>>>
>>
>> Thanks for testing, attached is a new version that set KDAB_INSTALL=OFF
>> to avoid KDAB prefix dir names. With this upcoming kdenlive-25.12.0 builds
>> fine.
>>
>> OK to import?
> 
> Would anyone be willing to review it? I would like to import it so that
> I can update KDE Gear to 25.12.

OK kn, but you may consider to

kbdbindings:
- drop default HOMEPAGE
- inline V into DIST_TUPLE and do PKGNAME=${DISTNAME:L}
- set NO_BUILD=Yes and run ${MODCMAKE_BUILD_TARGET} in pre-test
  like some ports do, otherwise this "header-only library" churns
  through 28 .cpp on every build

As you like.