Index | Thread | Search

From:
Stuart Henderson <stu@spacehopper.org>
Subject:
Re: Support data-dir from cabal package dependencies
To:
Greg Steuck <gnezdo@openbsd.org>, ports@openbsd.org
Date:
Wed, 7 Jan 2026 23:14:05 +0000

Download raw body.

Thread
On 2026/01/07 20:25, Matthias Kilian wrote:
> In general, I like your diff. Except for the invocation of
> populate-datadir.pl. IMHO this should be explicitely run using perl,
> like this:
> 
> 	perl ${PORTSDIR}/devel/cabal/populate-datadir.pl

yes.

> The reason is that I'm not sure wether executable bits are always
> correctly set when checking this out via cvs. And they aren't set
> for sure when just applying your diff.

they are kept, but please do not commit files with x bits to the tree.

> Otherwise, ok for me.
> 
> Ciao,
> 	Kili
>