Index | Thread | Search

From:
Klemens Nanni <kn@openbsd.org>
Subject:
Re: Update devel/github-cli port to version 2.83.2
To:
David Uhden Collado <daviduhden@gmail.com>, ports@openbsd.org
Date:
Thu, 08 Jan 2026 18:23:01 +0000

Download raw body.

Thread
08.01.2026 20:40, Klemens Nanni пишет:
> 07.01.2026 20:07, David Uhden Collado пишет:
>> Hello all,
>>
>> Attached to this email is a patch that updates the devel/github-cli port from version 2.79.0 to 2.83.2.
> 
> How did you update the port?
> 
> When I run the following, which is how I've been updating the g*-cli
> ports all the time, recent versions started failing to fetch:
> 
> 	# fetch new version without modules
> 	>| modules.inc
> 	make makesum
> 	make extract
> 
> 	# update and fetch (new) modules
> 	make modgo-gen-modules >| m
> 	mv m modules.inc
> 	make makesum -j$(make show=MAKE_JOBS)
> 
> 	# build and test
> 	make build
> 	make update-plist
> 	make update
> 
> 
> ===>  Checking files for github-cli-2.83.2
>>> Fetch https://proxy.golang.org/github.com/go-openapi/swag/jsonutils/@v/v0.0.0-00010101000000-000000000000.mod
> ftp: Error retrieving https://proxy.golang.org/github.com/go-openapi/swag/jsonutils/@v/v0.0.0-00010101000000-000000000000.mod: 404 Not Found
> *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:3310 '/usr/ports/distfiles/go_modules/github.com/go-openapi/swag/jsonutils/@v/v0.0.0-00010101000000-000000000000.mod')
> *** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2531 '_internal-fetch-all': @cd /p/devel/github-cli && PKGPATH=devel/github-cli e...)
> *** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2710 'fetch-all': @lock=github-cli-2.83.2;  export _LOCKS_HELD=" github-cli-2.83....)
> *** Error 2 in /p/devel/github-cli (/usr/ports/infrastructure/mk/bsd.port.mk:2346 'makesum': @make fetch-all _MAKESUM=true)

Should've clarified:  Your diff works, but is not what I get with our
go-module(5) target:

--- modules.inc.kn	Thu Jan  8 21:11:43 2026
+++ modules.inc.david	Thu Jan  8 21:10:33 2026
@@ -1449,9 +1449,6 @@
 	github.com/go-openapi/jsonpointer							 v0.21.0 \
 	github.com/go-openapi/swag								 v0.23.0 \
 	github.com/go-openapi/swag								 v0.23.1 \
-	github.com/go-openapi/swag/jsonutils							 v0.0.0-00010101000000-000000000000 \
-	github.com/go-openapi/swag/typeutils							 v0.0.0-00010101000000-000000000000 \
-	github.com/go-openapi/swag/yamlutils							 v0.0.0-00010101000000-000000000000 \
 	github.com/go-pdf/fpdf									 v0.5.0 \
 	github.com/go-sql-driver/mysql								 v1.9.1 \
 	github.com/go-sql-driver/mysql	


Manually removing these tree lines unbreaks my update script.

So your diff is fine and I'll be committing it in a bit,
but where should find out what's up with these module versions.

> 
> In-tree 2.79.0 does not exhibit this failure, so it must be some
> upstream change.  Back then the first release after that came out
> I briefly looked into it, but did not find the culprit.
> 
> From then on so far I just checked newer versions and hoped for
> it to fix itself...
> 
>>
>> I have tested this update on the amd64 platform and everything appears to work correctly overall. The only exception is the interactive authentication via gh auth login, which is still not functioning; however, this issue was already present prior to the update. It would be worthwhile to investigate a way to fix this in the future.
> 
> Is this an auth-specific problem or are you about interactive input?
> 
> Afaict, the problem with prompts (same for gitlab-cli) came with our
> syscalls changes that broke the module doing the work;  however,
> I did not check which module exactly or what it does now.
> 
>>
>> I look forward to any feedback or suggestions.
>>
>> Best regards,
>> David.
>