On 2026/01/19 17:19, Sebastian Reitenbach wrote:
> Hi,
> 
> this updates fluidsynth to latest 2.5.2. They started to use a submodule which requires to
> fetch it before building.
> 
> Lightly tested with midish connecting my midi keyboard controller to it. 
> 
> any comments, test reports etc. welcome.
> 
> 
> cheers,
> Sebastian

Your diff drops sdl2. I'm not sure what effect that has on other
programs which use fluidsynth that themselves use sdl - any ideas?
(Perhaps it would make sense to switch to sdl3 instead, but similarly
I don't know what effect that will have).

Please use DIST_TUPLE to fetch the submodule - you can do this on
top of your diff:

--- Makefile-	Mon Jan 19 17:17:53 2026
+++ Makefile	Mon Jan 19 17:17:43 2026
@@ -5,9 +5,7 @@ GH_ACCOUNT =		FluidSynth
 GH_PROJECT =		fluidsynth
 GH_TAGNAME =		v2.5.2
 
-GCEM_V =		012ae73c6d0a2cb09ffe86475f5c6fba3926e200
-SITES.gcem =		https://github.com/kthohr/gcem/archive/
-DISTFILES.gcem =	${GCEM_V}.zip
+DIST_TUPLE =		github kthohr gcem 012ae73c6d0a2cb09ffe86475f5c6fba3926e200 gcem
 
 SHARED_LIBS +=	fluidsynth           4.1      # 3.5.1 (grep LIB_VERSION CMakeLists.txt)
 
@@ -43,10 +41,6 @@ CONFIGURE_ARGS =	-DCMAKE_DISABLE_FIND_PACKAGE_Doxygen=
 			-Denable-sdl3=OFF
 
 DEBUG_PACKAGES = ${BUILD_PACKAGES}
-
-post-extract:
-	rmdir ${WRKSRC}/gcem
-	mv ${WRKDIR}/gcem-${GCEM_V} ${WRKSRC}/gcem
 
 post-patch:
 	cp ${FILESDIR}/fluid_sndio.c ${WRKSRC}/src/drivers/