Index | Thread | Search

From:
Klemens Nanni <kn@openbsd.org>
Subject:
Re: [NEW] devel/tomlplusplus
To:
SASANO Takayoshi <uaa@mx5.nisiq.net>, "Anthony J. Bentley" <anthony@anjbe.name>, ports@openbsd.org, Antoine Jacoutot <ajacoutot@bsdfrog.org>
Date:
Sun, 08 Feb 2026 15:17:08 +0000

Download raw body.

Thread
08.02.2026 18:13, Stuart Henderson пишет:
> +cc kn@ (goldendict-ng maintainer)
> 
> On 2026/02/08 20:37, SASANO Takayoshi wrote:
>> Hi,
>>
>> I just commited devel/tomlplusplus to repo.
>>
>>>>> 1. building goldendict-ng with this installed
>>>>> 2. "make configure" with tomlplusplus installed, then pkg_delete
>>>>> tomlplusplus, then build goldendict-ng
>>>>
>>>> both looks no error but, goldendict-ng refers system-provided
>>>> toml++ package.
>>>>
>>>> remove thirdparty/toml++/toml.hpp after "make configure",
>>>> no error with installed tomlplusplus, error occurs without it.
>>>
>>> That is fine, cases 1 and 2 both can occur during bulk package builds,
>>> but the third case you describe will not ever happen.
>>
>> Should I change textproc/goldendict-ng uses system-provided toml++,
>> like this change?
> 
> As a header-only library, add it to BUILD_DEPENDS, not LIB_DEPENDS.
> Please bump REVISION as well. Then it's ok sthen@ as long as kn agrees.

Sure, fine with me, thanks.

> 
>> Index: Makefile
>> ===================================================================
>> RCS file: /cvs/ports/textproc/goldendict-ng/Makefile,v
>> diff -u -p -r1.6 Makefile
>> --- Makefile	14 Apr 2025 19:18:38 -0000	1.6
>> +++ Makefile	8 Feb 2026 11:22:32 -0000
>> @@ -40,6 +40,7 @@ LIB_DEPENDS =		archivers/bzip2 \
>>  			graphics/ffmpeg \
>>  			textproc/hunspell \
>>  			textproc/icu4c \
>> +			textproc/tomlplusplus \
>>  			x11/qt6/qt5compat \
>>  			x11/qt6/qtmultimedia \
>>  			x11/qt6/qtspeech \
>> @@ -51,6 +52,7 @@ RUN_DEPENDS =		devel/desktop-file-utils
>>  CONFIGURE_ARGS =	-DCMAKE_DISABLE_FIND_PACKAGE_Git=ON \
>>  			-DUSE_ALTERNATIVE_NAME=ON \
>>  			-DUSE_SYSTEM_FMT=ON \
>> +			-DUSE_SYSTEM_TOML=ON \
>>  			-DWITH_TTS=ON
>>  
>>  # ${WRKSRC}/CMakeLists.txt =OFF does not require it, but
>>
>> Regards,
>> -- 
>> SASANO Takayoshi (JG1UAA) <uaa@mx5.nisiq.net>
>>