Still waiting for feedback.

Ping.

Kind regards,
Nazarenko Mykyta

Apr 6, 2026 4:31:45 PM mykyta@nazarenko.sbs:

> Fixed.
> 
> Patch with pledge(2) removed, but I think I will add it in the future, ofc with unveil(2), comments and explanation.
> 
> But idk what to do in relation to tdlib, because ( as mentioned in Makefile ), a certain version of the library is tied to a certain version of nchat. The developer himself told me about this problem. So I'm thinking it's not possible.
> 
> With best regards,
> Nazarenko Mykyta
> 
> Apr 5, 2026 5:26:17 PM Klemens Nanni <kn@openbsd.org>:
> 
>> 05.04.2026 17:07, mykyta@nazarenko.sbs пишет:
>>> Hi there!
>>> 
>>> nchat - is a terminal-based Telegram, WhatsApp and Signal client.
>>> 
>>> Most terminal-based clients for Telegram that exist at the moment do not have such a wide range of functionality and ease of use, so it would be very appropriate to add nchat into ports-tree.
>>> 
>>> WhatsApp and Signal support is currently impossible due to limitations in static-linking ( libs that use cgo cannot be static-linked normally ).
>>> 
>>> Feedback? OK?
>>> 
>>> With best regards,
>>> Nazarenko Mykyta
>> 
>> Just had a quick look, didn't build it:
>> 
>> - top comment/link about protocols seems unrelated to architectures?
>> 
>> - if this is Go and links statically, do we want to set WANTLIB anyway
>>   as is done with dlopen()ed libs to get package bumps on lib updates?
>> 
>> - if only Telegram is supported, COMMENT could mention that;
>>   "messaging client" is pretty vague and does not mention CLI/GUI, either
>> 
>> - GH_* sets DISTNAME and HOMEPAGE, no need for V
>> 
>> - can net/tdlib/ be used like net/py-telegram and net/tdesktop do?
>> 
>> - is DPB_PROPERTIES related to that "note" comment?
>>   why does it need that?
>> 
>> - MODULES (in your case) already sets CONFIGURE_STYLE;
>>   no need or +=, = is fine
>> 
>> - pledge marker usually is "uses pledge()" without blank line after it;
>>   the patch adding pledge has header and code comments that don't help;
>>   "stdio rpath wpath cpath inet fattr flock tty proc" is quite broad:
>>   - what does it "proc", but not "exec" for?
>>   - can unveil() be used?
>>   better leave out such patches during import or explain things in detail,
>>   otherwise users might get a broken port and/or porters have to redo
>>   all your work in order to understand how you arrived at that promise.
>> 
>> - COPMILER omitting "base-gcc" usually warrants a comment explaining why,
>>   e.g. "C++11", "thread local storage" or so
>> 
>> - ccache must not be a BUILD_DEPEND, surely it works without?
>>   there's USE_CCACHE for that doing all the setup, see bsd.port.mk(5)
>> 
>> - copy/pasted DESCR needs line wrapping, technically says that OpenBSD
>>   is not supported and mentions protocols you said don't work.