Index | Thread | Search

From:
Stuart Henderson <stu@spacehopper.org>
Subject:
Re: [patch] geo/py-fiona-1.10.1p5
To:
Marco van Hulten <marco@hulten.org>
Cc:
ports@openbsd.org
Date:
Thu, 30 Apr 2026 18:59:49 +0100

Download raw body.

Thread
On 2026/04/30 18:17, Marco van Hulten wrote:
> To import fiona, devel/py-attrs was needed as run dep.
> 
> In addition, I excluded network tests and enabled SEPARATE_BUILD.

python ports do not do SEPARATE_BUILD, please drop SEPARATE_BUILD

I prefer to _not_ exclude network tests if they work. Just add a
"uses network" comment in the Makefile.

>  BUILD_DEPENDS =	${RUN_DEPENDS} \

yuk, is that actually needed?

> @@ -28,6 +33,7 @@
>  LIB_DEPENDS =	geo/gdal
>  
>  RUN_DEPENDS =	geo/py-cligj \
> +		devel/py-attrs \
>  		devel/py-click \
>  		devel/py-click-plugins \
>  		devel/py-munch \

dependencies = [
    "attrs>=19.2.0",
    "certifi",
    "click~=8.0",
    "click-plugins>=1.0",
    "cligj>=0.5",
    'importlib-metadata;python_version<"3.10"',
]

it's also missing certifi

looks like the dep on six can be removed

> +SEPARATE_BUILD =	Yes

please drop that