Index | Thread | Search

From:
Stuart Henderson <stu@spacehopper.org>
Subject:
Re: sysutils/bacula switch to Qt6
To:
Rafael Sadowski <rafael@sizeofvoid.org>
Cc:
The OpenBSD ports mailing-list <ports@openbsd.org>
Date:
Tue, 26 May 2026 10:08:20 +0100

Download raw body.

Thread
On 2026/05/26 07:20, Rafael Sadowski wrote:
> +REVISION-bat=		1
> +REVISION-sqlite3=	1
> +REVISION-main=		0
> +REVISION-mysql=		0
> +REVISION-pgsql=		0
>  REVISION-server=	0
>  
> +REVISION-server=	1

this leaves two REVISION-server lines, please either drop the first
one or, since you bump every subpackage, you could just set REVISION=1
and drop other REVISION-* lines.

> @@ -145,10 +150,8 @@ RUN_DEPENDS-server=	lang/gawk
>  CONFIGURE_ARGS +=	--disable-bat
>  .else
>  CONFIGURE_ARGS +=	--enable-bat
> -# something in tray-monitor seems to still depend on this (at least,
> -# it complains if junked during the build), though it looks like the dep
> -# is supposed to have been removed by now.
> -BUILD_DEPENDS +=	x11/qwt
> +# Depends on qwt header files only
> +BUILD_DEPENDS=		x11/qwt,-common
>  .endif

optional but this far into a fairly long Makefile, += instead of = would
be a bit safer in case someone later adds a BDEP earlier in the file
without changing this to +=.

otherwise lgtm.