Pascal Stumpf wrote:
> Hi David,
> 
> thanks for the update diff.  A few nits:
> 
> On Tue, 26 May 2026 22:28:00 +0000, David Uhden Collado wrote:
>> Hello,
>>
>> Please find attached a patch that updates the net/i2p port to version
>> 2.12.0.
>>
>> The upstream release notes and full list of changes are available at:
>>
>> https://i2p.net/en/blog/2026/02/09/i2p-2.11.0-release/
>> https://i2p.net/en/blog/2026/04/20/i2p-2.12.0-release/
>>
>> I also updated the HOMEPAGE to the new canonical project site:
>>
>> https://i2p.net/
>>
>> In short, the changes since 2.10.0 include the switch to Java 17+, Jetty
>> 12, broader post-quantum crypto support, and SAMv3 improvements. The
>> 2.12.0 release then continues the post-quantum work and fixes a SAMv3
>> lookup issue.
>>
>> In addition to the version bump, I have preserved the existing
>> OpenBSD-specific adjustments for the port, including the local wrapper
>> and runtime configuration changes.
>>
>> I also updated the package list for the new upstream files, including
>> the additional reseed and router certificates shipped in this release.
>> The package list now uses /var/empty as the _i2p account home so
>> installation does not warn about a missing home directory.
> 
> This change is wrong.  The _i2p user needs a writable home directory,
> the warning is harmless.

I tried rebuilding and reinstalling the package with this change in the 
PLIST file, and when I start the daemon using the rc script, it is 
automatically created in the /var/i2p directory with the correct 
permissions. Another option would be to create the directory directly 
when the package is installed, even if it is empty.

> 
>> I used the GitHub release archive as the source tarball because the
>> previous upstream download location could not be resolved from my build
>> environment, while the GitHub archive was available and matched the
>> 2.12.0 release tag.
> 
> In this case, the new homepage provides a source tarball for download,
> so it is preferable to use that instead of Github.

I did think there had to be another way to get the source code using the 
same approach as before; it's my fault for not looking into it more 
thoroughly. The domain change did strike me as odd - I wasn't sure if it 
was legitimate or some kind of impersonation of the original project - 
but it seems to be completely legitimate.

> 
>> Thank you for your time and consideration.
>>
>> Best regards,
>> David
>>>> text/x-patch content
> 
> 
> Everything else looks good.  I'm testing the following for a bit and
> will commit the update shortly:
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/i2p/Makefile,v
> diff -u -p -r1.28 Makefile
> --- Makefile	23 Mar 2026 19:02:40 -0000	1.28
> +++ Makefile	29 May 2026 15:56:45 -0000
> @@ -1,13 +1,12 @@
>   COMMENT=	i2p routing protocol
>   
> -V =		2.10.0
> +V =		2.12.0
>   DISTNAME =	i2psource_${V}
>   PKGNAME =	i2p-${V}
> -REVISION =	0
>   
>   CATEGORIES=	net
>   
> -HOMEPAGE=	https://geti2p.net/en/
> +HOMEPAGE=	https://i2p.net/en/
>   
>   MAINTAINER=	Pascal Stumpf <pascal@stumpf.co>
>   
> @@ -19,7 +18,7 @@ EXTRACT_SUFX =	.tar.bz2
>   
>   WANTLIB +=	gmp
>   
> -SITES =		https://files.i2p-projekt.de/${V}/
> +SITES =		https://files.i2p.net/${V}/
>   
>   MODULES=	java
>   MODJAVA_VER=	17
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/net/i2p/distinfo,v
> diff -u -p -r1.15 distinfo
> --- distinfo	6 Nov 2025 20:43:36 -0000	1.15
> +++ distinfo	29 May 2026 15:56:51 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (i2psource_2.10.0.tar.bz2) = O2Ubdh2lMCQvbbZTY5H7eBvI4HEpVArn6WiCvLe/I3U=
> -SIZE (i2psource_2.10.0.tar.bz2) = 33770261
> +SHA256 (i2psource_2.12.0.tar.bz2) = 5jLqG4qczEoRludhUEftFuMiigoXkaCpA2JTPu74kZI=
> +SIZE (i2psource_2.12.0.tar.bz2) = 39528116
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/net/i2p/pkg/PLIST,v
> diff -u -p -r1.15 PLIST
> --- pkg/PLIST	6 Nov 2025 20:43:36 -0000	1.15
> +++ pkg/PLIST	29 May 2026 15:57:58 -0000
> @@ -38,6 +38,7 @@ share/i2p/certificates/reseed/
>   share/i2p/certificates/reseed/admin_at_stormycloud.org.crt
>   share/i2p/certificates/reseed/arnavbhatt288_at_mail.i2p.crt
>   share/i2p/certificates/reseed/creativecowpat_at_mail.i2p.crt
> +share/i2p/certificates/reseed/diyarciftci_at_protonmail.com.crt
>   share/i2p/certificates/reseed/echelon3_at_mail.i2p.crt
>   share/i2p/certificates/reseed/hankhill19580_at_gmail.com.crt
>   share/i2p/certificates/reseed/hottuna_at_mail.i2p.crt
> @@ -47,8 +48,10 @@ share/i2p/certificates/reseed/lazygravy_
>   share/i2p/certificates/reseed/r4sas-reseed_at_mail.i2p.crt
>   share/i2p/certificates/reseed/rambler_at_mail.i2p.crt
>   share/i2p/certificates/reseed/reseed_at_diva.exchange.crt
> +share/i2p/certificates/reseed/sahil_at_mail.i2p.crt
>   share/i2p/certificates/reseed/unixeno_at_cubicchaos.net.crt
>   share/i2p/certificates/router/
> +share/i2p/certificates/router/admin_at_stormycloud.org.crt
>   share/i2p/certificates/router/echelon_at_mail.i2p.crt
>   share/i2p/certificates/router/hankhill19580_at_gmail.com.crt
>   share/i2p/certificates/router/zzz_at_mail.i2p.crt
> @@ -307,8 +310,15 @@ share/i2p/eepsite/
>   share/i2p/eepsite/cgi-bin/
>   share/i2p/eepsite/contexts/
>   share/i2p/eepsite/contexts/base-context.xml
> -share/i2p/eepsite/contexts/cgi-context.xml
> +share/i2p/eepsite/contexts/cgi-context.xml.disabled
>   share/i2p/eepsite/docroot/
> +share/i2p/eepsite/docroot/.resources/
> +share/i2p/eepsite/docroot/.resources/000.html
> +share/i2p/eepsite/docroot/.resources/403.html
> +share/i2p/eepsite/docroot/.resources/404.html
> +share/i2p/eepsite/docroot/.resources/4xx.html
> +share/i2p/eepsite/docroot/.resources/5xx.html
> +share/i2p/eepsite/docroot/.resources/README.txt
>   share/i2p/eepsite/docroot/favicon.ico
>   share/i2p/eepsite/docroot/help/
>   share/i2p/eepsite/docroot/help/index.html