Index | Thread | Search

From:
Matthieu Herrb <matthieu@openbsd.org>
Subject:
[llvm22] fix x11/xbae or remove (with productivity/xquote)
To:
ports@openbsd.org
Date:
Tue, 2 Jun 2026 15:51:17 +0200

Download raw body.

Thread
Hi

The (simple) patch below fixes build of xbae. (It's a Motif widget
set, mostly use for it's matrix widget to display tabular data).

But the only consumer in ports in productivity/xquote, which is
completely out of date. Not only it uses imake as its build sysstem,
but its default configuration is unable to fetch any useful data (301 errors
everywhere).

I'd be inclinded to remove both ports (altough I've some attachement
to XBae widgets that I've used at $DAYJOB 20 or more years ago) rather
than keep this memories from the past. Imho the ports tree is not a
software archeology project. Making xquote useful is out of my scope.


comments ? ok to remove, or just ok to patch xbae ?

Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/xbae/Makefile,v
diff -u -p -u -r1.30 Makefile
--- Makefile	21 Jul 2025 16:10:44 -0000	1.30
+++ Makefile	2 Jun 2026 13:18:18 -0000
@@ -1,7 +1,7 @@
 COMMENT=	Motif-based table widget
 
 DISTNAME=	xbae-4.60.4
-REVISION=	19
+REVISION=	20
 
 SHARED_LIBS=	Xbae 4.60
 
Index: patches/patch-src_Methods_c
===================================================================
RCS file: patches/patch-src_Methods_c
diff -N patches/patch-src_Methods_c
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ patches/patch-src_Methods_c	2 Jun 2026 13:17:08 -0000
@@ -0,0 +1,14 @@
+Fix build with llvm22
+
+Index: src/Methods.c
+--- src/Methods.c.orig
++++ src/Methods.c
+@@ -1688,7 +1688,7 @@ DoEditCell(XbaeMatrixWidget mw, XEvent * event, int ro
+                                          * The event must have occurred in a legal position
+                                          * otherwise control wouldn't have made it here
+                                          */
+-                                        xbaeEventToRowColumn(mw, event, &r, &c, &x, &y);
++                                        xbaeEventToRowColumn((Widget)mw, event, &r, &c, &x, &y);
+                                         x -= mw->matrix.cell_shadow_thickness;
+                                         y -= mw->matrix.cell_shadow_thickness;
+                                         position = XmTextXYToPos(TextField(mw), x, y);

-- 
Matthieu Herrb